You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Kenneth Knowles (Jira)" <ji...@apache.org> on 2022/01/12 03:50:06 UTC
[jira] [Updated] (BEAM-6441) cut_release_branch.sh should not push to master without verification and a PR
[ https://issues.apache.org/jira/browse/BEAM-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kenneth Knowles updated BEAM-6441:
----------------------------------
This Jira ticket has a pull request attached to it, but is still open. Did the pull request resolve the issue? If so, could you please mark it resolved? This will help the project have a clear view of its open issues.
> cut_release_branch.sh should not push to master without verification and a PR
> -----------------------------------------------------------------------------
>
> Key: BEAM-6441
> URL: https://issues.apache.org/jira/browse/BEAM-6441
> Project: Beam
> Issue Type: Sub-task
> Components: build-system
> Reporter: Kenneth Knowles
> Priority: P3
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently, the cut_release_branch.sh does many things:
> - Edits files in place to update the version
> - Makes a local commit
> - Pushing the local commit to master
> - Creates a new branch
> - Edits files in place to update the version
> - Pushes the release branch
> I think all of this except the push to master are OK. It is possible that we have something - website, examples, new places where the version is hardcoded, etc, that get broken in this process. Moving from x-SNAPSHOT to (x+1)-SNAPSHOT is easy to do in a pull request and safe. The release branch creation does not need to be synchronized with this.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)