You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by we...@apache.org on 2009/07/03 12:59:40 UTC

svn commit: r790855 - /myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitIdProxy.java

Author: werpu
Date: Fri Jul  3 10:59:39 2009
New Revision: 790855

URL: http://svn.apache.org/viewvc?rev=790855&view=rev
Log:
https://issues.apache.org/jira/browse/MYFACES-2116

small refactoring of a method name

Modified:
    myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitIdProxy.java

Modified: myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitIdProxy.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitIdProxy.java?rev=790855&r1=790854&r2=790855&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitIdProxy.java (original)
+++ myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/component/visit/PartialVisitIdProxy.java Fri Jul  3 10:59:39 2009
@@ -59,14 +59,21 @@
         return _inverseCache;
     }
 
-
+    /**
+     * Partial visit id proxy constructor
+     * @param separatorChar the separator char for the reverse indexing
+     * ie: ':' means view1:view2:component the ':' will be used for splitting
+     * which is the standard char for now according to the specs
+     *
+     * @param ids a set of ids client ids to be processed
+     */
     public PartialVisitIdProxy(char separatorChar, Collection<String> ids) {
         _ids = new HashSet<String>(ids);
         _separatorChar = separatorChar;
         initCaches();
     }
 
-    private void removeFromCache(String clientId) {
+    private void removeFromIndex(String clientId) {
         char[] ids = clientId.toCharArray();
         
         StringBuilder finalContainer = new StringBuilder(clientId.length());
@@ -171,7 +178,7 @@
         if(!_ids.remove((String)o)) {
             return false;
         }
-        removeFromCache((String)o);
+        removeFromIndex((String)o);
         return true;
     }
 
@@ -240,7 +247,7 @@
         public void remove() {
            
             _delegate.remove();
-            removeFromCache(_currentValue);
+            removeFromIndex(_currentValue);
         }
 
     }