You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@joshua.apache.org by mjpost <gi...@git.apache.org> on 2016/08/23 03:06:05 UTC
[GitHub] incubator-joshua pull request #44: Moved test case files
GitHub user mjpost opened a pull request:
https://github.com/apache/incubator-joshua/pull/44
Moved test case files
Moved test cases files from resources/ to src/test/resources. Also fixed bug in LmOovFeatureTest.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-joshua JOSHUA-299
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-joshua/pull/44.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #44
----
commit 20e6bf4b069d261718f819a72c9e9b2c62bcbb26
Author: Matt Post <po...@cs.jhu.edu>
Date: 2016-08-22T22:03:53Z
Moved test file locations from resources/ to src/test/resources
commit 4812fedee89d3a6dac4e8333a1d62242f3b5ac9c
Author: Matt Post <po...@cs.jhu.edu>
Date: 2016-08-23T02:36:09Z
missed one
commit d4fdbfd88bab99e244d3ed1fc9cff4ba5e6d124c
Author: Matt Post <po...@cs.jhu.edu>
Date: 2016-08-23T02:57:06Z
bugfix: resetting global decoder state
We are getting random failures in LmOovFeatureTest.java, but only when run as a group. I printed the stack trace around the error and noticed it's a call to getting the state index in ComputeNodeResult, with a state index of 1, which shouldn't happen because only one LM is loaded. So it seems that the bug is cause by some earlier test not calling Decoder.resetGlobalState() in cleanup. So I put a call to that in the constructor. This passes the tests but I'm not sure it's correct, and it's definitely not the right way to go about things. The ideal way to solve this is to get rid of global state.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-joshua pull request #44: Moved test case files
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-joshua/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---