[GitHub] [jena] afs commented on a diff in pull request #1806: Misc

["afs (via GitHub)" <gi...@apache.org>]

afs commented on code in PR #1806:
URL: https://github.com/apache/jena/pull/1806#discussion_r1141784993


##########
.github/workflows/maven.yml:
##########
@@ -30,4 +30,4 @@ jobs:
         distribution: 'temurin'
         java-version: '11'
     - name: Build with Maven
-      run: mvn -B verify -Pdev --file pom.xml
+      run: mvn -B -o --file pom.xml -Dmaven.javadoc.skip=true verify

Review Comment:
   The release has to use Java17 outputting Java11 byte code because of Javadoc probems. Fixes have not been fully backported to Java11.
   
   That means one check is needed - does the code compile on Java11 - not the javadoc.
   
   It' probably less of an issue these days but it used to be possible to have JDK library calls at the level of the compiler, not the target, and then they weren't available at runtime.
   
   This job checks that Java11 can compile the code.
   
   Jenkins does make Javadoc, as do the other github actions (Linux, MacOS). It's this one case (Windows+Java11) that seems more unstable.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org