You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by va...@apache.org on 2021/11/23 20:45:55 UTC

[couchdb] 01/01: Fix Jenkins email quoting failures

This is an automated email from the ASF dual-hosted git repository.

vatamane pushed a commit to branch jenkins-fix-quoting-main
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit 80aad875d0b0f6dfda3ead2d7da733865555c521
Author: Nick Vatamaniuc <va...@gmail.com>
AuthorDate: Tue Nov 23 11:13:42 2021 -0500

    Fix Jenkins email quoting failures
    
    Should fix:
    ```
    Warning: A secret was passed to "mail" using Groovy String interpolation, which is insecure.
    ```
---
 build-aux/Jenkinsfile.full | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/build-aux/Jenkinsfile.full b/build-aux/Jenkinsfile.full
index 144c18b..20b8989 100644
--- a/build-aux/Jenkinsfile.full
+++ b/build-aux/Jenkinsfile.full
@@ -54,7 +54,6 @@ pipeline {
 
   environment {
     COUCHAUTH = credentials('couchdb_vm2_couchdb')
-    recipient = 'notifications@couchdb.apache.org'
     COUCHDB_IO_LOG_DIR = '/tmp/couchjslogs'
     // Following fix an issue with git <= 2.6.5 where no committer
     // name or email are present for reflog, required for git clone
@@ -754,20 +753,20 @@ pipeline {
 
   post {
     success {
-      mail to: "${env.recipient}",
-        replyTo: "${env.recipient}",
+      mail to: 'notifications@couchdb.apache.org',
+        replyTo: 'notifications@couchdb.apache.org',
         subject: "[Jenkins] SUCCESS: ${currentBuild.fullDisplayName}",
         body: "Yay, we passed. ${env.RUN_DISPLAY_URL}"
     }
     unstable {
-      mail to: "${env.recipient}",
-        replyTo: "${env.recipient}",
+      mail to: 'notifications@couchdb.apache.org',
+        replyTo: 'notifications@couchdb.apache.org',
         subject: "[Jenkins] SUCCESS: ${currentBuild.fullDisplayName}",
         body: "Eep! Build is unstable... ${env.RUN_DISPLAY_URL}"
     }
     failure {
-      mail to: "${env.recipient}",
-        replyTo: "${env.recipient}",
+      mail to: 'notifications@couchdb.apache.org',
+        replyTo: 'notifications@couchdb.apache.org',
         subject: "[Jenkins] FAILURE: ${currentBuild.fullDisplayName}",
         body: "Boo, we failed. ${env.RUN_DISPLAY_URL}"
     }