You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/01 07:18:52 UTC
[GitHub] [dubbo-go] zouyx opened a new pull request #578: Rft : Optimize lock for zookeeper registry
zouyx opened a new pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
1. Optimize lock for zookeeper registry
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=h1) Report
> Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/c024ce17b3fcd636f4f9e690bfb3a5a3a7f39c32&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `52.52%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #578 +/- ##
=======================================================
- Coverage 65.85% 65.82% -0.03%
=======================================================
Files 203 203
Lines 10558 10556 -2
=======================================================
- Hits 6953 6949 -4
+ Misses 2935 2934 -1
- Partials 670 673 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `69.01% <0.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `68.51% <0.00%> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `55.31% <0.00%> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.05% <ø> (-0.53%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.09% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `42.10% <20.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `54.24% <54.16%> (-1.46%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `70.88% <88.88%> (+3.79%)` | :arrow_up: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.11% <90.00%> (ø)` | |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=footer). Last update [b364f31...977fffa](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=h1) Report
> Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/c024ce17b3fcd636f4f9e690bfb3a5a3a7f39c32&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `52.74%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #578 +/- ##
=======================================================
+ Coverage 65.85% 65.87% +0.01%
=======================================================
Files 203 203
Lines 10558 10551 -7
=======================================================
- Hits 6953 6950 -3
+ Misses 2935 2926 -9
- Partials 670 675 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `69.01% <0.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `68.51% <0.00%> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `55.31% <0.00%> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.05% <ø> (-0.53%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.09% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `42.10% <20.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.40% <55.00%> (-0.30%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `70.88% <88.88%> (+3.79%)` | :arrow_up: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.11% <90.00%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=footer). Last update [b364f31...f7ea5f2](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#discussion_r433082642
##########
File path: registry/zookeeper/registry.go
##########
@@ -156,12 +156,15 @@ func (r *zkRegistry) DoRegister(root string, node string) error {
}
func (r *zkRegistry) DoUnregister(root string, node string) error {
- r.cltLock.Lock()
- defer r.cltLock.Unlock()
- if !r.ZkClient().ZkConnValid() {
+ client := r.client
Review comment:
copy new var for operation
##########
File path: registry/zookeeper/registry.go
##########
@@ -252,9 +255,7 @@ func (r *zkRegistry) getListener(conf *common.URL) (*RegistryConfigurationListen
zkListener = NewRegistryConfigurationListener(r.client, r, conf)
if r.listener == nil {
- r.cltLock.Lock()
Review comment:
`client := r.client` is atomic
##########
File path: remoting/zookeeper/client.go
##########
@@ -468,9 +464,7 @@ func (z *ZookeeperClient) RegisterTemp(basePath string, node string) (string, er
err = errNilZkClientConn
data = []byte("")
zkPath = path.Join(basePath) + "/" + node
- z.Lock()
conn := z.Conn
Review comment:
as above
##########
File path: remoting/zookeeper/client.go
##########
@@ -446,9 +444,7 @@ func (z *ZookeeperClient) Delete(basePath string) error {
)
err = errNilZkClientConn
- z.Lock()
conn := z.Conn
Review comment:
as above
##########
File path: remoting/zookeeper/client.go
##########
@@ -419,9 +419,7 @@ func (z *ZookeeperClient) CreateWithValue(basePath string, value []byte) error {
for _, str := range strings.Split(basePath, "/")[1:] {
tmpPath = path.Join(tmpPath, "/", str)
err = errNilZkClientConn
- z.Lock()
conn := z.Conn
Review comment:
`conn := z.Conn` is atomic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=h1) Report
> Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/c024ce17b3fcd636f4f9e690bfb3a5a3a7f39c32&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `52.74%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #578 +/- ##
=======================================================
+ Coverage 65.85% 65.87% +0.01%
=======================================================
Files 203 203
Lines 10558 10551 -7
=======================================================
- Hits 6953 6950 -3
+ Misses 2935 2926 -9
- Partials 670 675 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `69.01% <0.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `68.51% <0.00%> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `55.31% <0.00%> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.05% <ø> (-0.53%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.09% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `42.10% <20.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.40% <55.00%> (-0.30%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `70.88% <88.88%> (+3.79%)` | :arrow_up: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.11% <90.00%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=footer). Last update [b364f31...9c623ec](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=h1) Report
> Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/c024ce17b3fcd636f4f9e690bfb3a5a3a7f39c32&el=desc) will **increase** coverage by `0.23%`.
> The diff coverage is `60.57%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #578 +/- ##
=======================================================
+ Coverage 65.85% 66.09% +0.23%
=======================================================
Files 203 203
Lines 10558 10558
=======================================================
+ Hits 6953 6978 +25
+ Misses 2935 2909 -26
- Partials 670 671 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `69.01% <0.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `68.51% <0.00%> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `55.31% <0.00%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.09% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `42.10% <20.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.70% <58.97%> (ø)` | |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `70.88% <88.88%> (+3.79%)` | :arrow_up: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.11% <90.00%> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.57% <100.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=footer). Last update [b364f31...1d1bbe0](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#discussion_r433794835
##########
File path: remoting/zookeeper/client.go
##########
@@ -487,7 +493,9 @@ func (z *ZookeeperClient) RegisterTempSeq(basePath string, data []byte) (string,
)
err = errNilZkClientConn
+ z.RLock()
Review comment:
big old, maybe u can define a func as follows
```Go
func (z *zookeeperClient) getConn() net.Conn {
z.RLock()
defer z.RUnlock()
return z.Conn
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=h1) Report
> Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/c024ce17b3fcd636f4f9e690bfb3a5a3a7f39c32&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `60.18%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #578 +/- ##
=======================================================
+ Coverage 65.85% 65.94% +0.08%
=======================================================
Files 203 203
Lines 10558 10558
=======================================================
+ Hits 6953 6962 +9
+ Misses 2935 2924 -11
- Partials 670 672 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `69.01% <0.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `68.51% <0.00%> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `55.31% <0.00%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.09% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `42.10% <20.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.70% <58.97%> (ø)` | |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `70.88% <88.88%> (+3.79%)` | :arrow_up: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.57% <88.88%> (ø)` | |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.11% <90.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=footer). Last update [b364f31...1d1bbe0](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=h1) Report
> Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/c024ce17b3fcd636f4f9e690bfb3a5a3a7f39c32&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `52.52%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #578 +/- ##
=======================================================
- Coverage 65.85% 65.82% -0.03%
=======================================================
Files 203 203
Lines 10558 10556 -2
=======================================================
- Hits 6953 6949 -4
+ Misses 2935 2934 -1
- Partials 670 673 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `69.01% <0.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `68.51% <0.00%> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `55.31% <0.00%> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.05% <ø> (-0.53%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.09% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `42.10% <20.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `54.24% <54.16%> (-1.46%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `70.88% <88.88%> (+3.79%)` | :arrow_up: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.11% <90.00%> (ø)` | |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.49% <0.00%> (-2.16%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=footer). Last update [b364f31...9c623ec](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=h1) Report
> Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/c024ce17b3fcd636f4f9e690bfb3a5a3a7f39c32&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `60.18%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #578 +/- ##
=======================================================
+ Coverage 65.85% 65.94% +0.08%
=======================================================
Files 203 203
Lines 10558 10558
=======================================================
+ Hits 6953 6962 +9
+ Misses 2935 2924 -11
- Partials 670 672 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `69.01% <0.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `68.51% <0.00%> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `55.31% <0.00%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.09% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `42.10% <20.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.70% <58.97%> (ø)` | |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `70.88% <88.88%> (+3.79%)` | :arrow_up: |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.57% <88.88%> (ø)` | |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.11% <90.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=footer). Last update [b364f31...9ae184f](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#discussion_r433085328
##########
File path: remoting/zookeeper/client.go
##########
@@ -419,9 +419,7 @@ func (z *ZookeeperClient) CreateWithValue(basePath string, value []byte) error {
for _, str := range strings.Split(basePath, "/")[1:] {
tmpPath = path.Join(tmpPath, "/", str)
err = errNilZkClientConn
- z.Lock()
conn := z.Conn
Review comment:
`conn := z.Conn` is atomic，and no need to know the newest value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=h1) Report
> Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/c024ce17b3fcd636f4f9e690bfb3a5a3a7f39c32&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `52.74%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #578 +/- ##
=======================================================
+ Coverage 65.85% 65.87% +0.01%
=======================================================
Files 203 203
Lines 10558 10551 -7
=======================================================
- Hits 6953 6950 -3
+ Misses 2935 2926 -9
- Partials 670 675 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `69.01% <0.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `68.51% <0.00%> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `55.31% <0.00%> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.05% <ø> (-0.53%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.09% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `42.10% <20.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.40% <55.00%> (-0.30%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `70.88% <88.88%> (+3.79%)` | :arrow_up: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.11% <90.00%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=footer). Last update [b364f31...db059d3](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=h1) Report
> Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/c024ce17b3fcd636f4f9e690bfb3a5a3a7f39c32&el=desc) will **increase** coverage by `0.07%`.
> The diff coverage is `58.71%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #578 +/- ##
=======================================================
+ Coverage 65.85% 65.93% +0.07%
=======================================================
Files 203 203
Lines 10558 10549 -9
=======================================================
+ Hits 6953 6955 +2
+ Misses 2935 2921 -14
- Partials 670 673 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `69.01% <0.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `68.51% <0.00%> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `55.31% <0.00%> (ø)` | |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.09% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `42.10% <20.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.70% <58.97%> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `67.22% <78.94%> (-1.36%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `70.88% <88.88%> (+3.79%)` | :arrow_up: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.11% <90.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=footer). Last update [b364f31...9ae184f](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #578: Rft : Optimize lock for zookeeper registry
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #578:
URL: https://github.com/apache/dubbo-go/pull/578#issuecomment-636663654
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=h1) Report
> Merging [#578](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=desc) into [feature/dubbo-2.7.5](https://codecov.io/gh/apache/dubbo-go/commit/c024ce17b3fcd636f4f9e690bfb3a5a3a7f39c32&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `52.74%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #578 +/- ##
=======================================================
+ Coverage 65.85% 65.87% +0.01%
=======================================================
Files 203 203
Lines 10558 10551 -7
=======================================================
- Hits 6953 6950 -3
+ Misses 2935 2926 -9
- Partials 670 675 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `69.01% <0.00%> (ø)` | |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `68.51% <0.00%> (ø)` | |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `55.31% <0.00%> (ø)` | |
| [remoting/zookeeper/client.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2NsaWVudC5nbw==) | `68.05% <ø> (-0.53%)` | :arrow_down: |
| [remoting/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVtb3Rpbmcvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `51.09% <0.00%> (ø)` | |
| [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `42.10% <20.00%> (ø)` | |
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `55.40% <55.00%> (-0.30%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `70.88% <88.88%> (+3.79%)` | :arrow_up: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `81.11% <90.00%> (ø)` | |
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `37.50% <0.00%> (-25.00%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/578/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=footer). Last update [b364f31...1d1bbe0](https://codecov.io/gh/apache/dubbo-go/pull/578?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org