You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/05 07:36:09 UTC

[GitHub] [apisix-dashboard] bzp2010 commented on a diff in pull request #2428: feat: basic support Apache APISIX 2.13.0

bzp2010 commented on code in PR #2428:
URL: https://github.com/apache/apisix-dashboard/pull/2428#discussion_r865609254


##########
api/conf/schema.json:
##########
@@ -401,6 +398,7 @@
 							"OPTIONS",
 							"PATCH",
 							"POST",
+							"PURGE",

Review Comment:
   As far as I can see, this change is not included in the APISIX 2.13 release branch, you need to reproduce it and check it.
   https://github.com/apache/apisix/blob/release/2.13/apisix/schema_def.lua#L525-L526



##########
api/conf/schema.json:
##########
@@ -1886,6 +1880,35 @@
 				"plugins": {
 					"type": "object"
 				},
+				"protocol": {
+					"properties": {
+						"conf": {
+							"description": "protocol-specific configuration",
+							"type": "object"
+						},
+						"name": {
+							"type": "string"
+						},
+						"superior_id": {
+							"anyOf": [
+								{
+									"maxLength": 64,
+									"minLength": 1,
+									"pattern": "^[a-zA-Z0-9-_.]+$",
+									"type": "string"
+								},
+								{
+									"minimum": 1,
+									"type": "integer"
+								}
+							]
+						}
+					},
+					"required": [
+						"name"
+					],
+					"type": "object"
+				},

Review Comment:
   ditto



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org