You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2023/02/25 00:06:18 UTC

[GitHub] [airflow] jedcunningham commented on pull request #29714: Add database check_migrations config

jedcunningham commented on PR #29714:
URL: https://github.com/apache/airflow/pull/29714#issuecomment-1444766801

   > The problem is not on applying migrations, but loading the migrations into memory without applying, which is needed for the check option.
   
   Could we use [REVISION_HEAD_MAP](https://github.com/apache/airflow/blob/671b88eb3423e86bb331eaf7829659080cbd184e/airflow/utils/db.py#L54) and `airflow.version` to short circuit in released versions of Airflow, leaving the expensive loading to dev envs?
   
   > I am concerned about prematurely handling it as we did with expose_config
   
   I think using a string from the start would mean we don't need the clunky backcompat code. Only an issue if the bool makes it to a release, but still, it probably makes sense to plan ahead in case we don't get to it before the next release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org