[jira] [Commented] (STORM-3222) Fix KafkaSpout internals to use LinkedList instead of ArrayList

["Stig Rohde Døssing (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-3222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16616260#comment-16616260 ] 

Stig Rohde Døssing commented on STORM-3222:
-------------------------------------------

Thanks [~arunmahadevan], merged to 1.x-branch and 1.1.x-branch.

> Fix KafkaSpout internals to use LinkedList instead of ArrayList
> ---------------------------------------------------------------
>
>                 Key: STORM-3222
>                 URL: https://issues.apache.org/jira/browse/STORM-3222
>             Project: Apache Storm
>          Issue Type: Improvement
>    Affects Versions: 2.0.0, 1.2.2
>            Reporter: Arun Mahadevan
>            Assignee: Arun Mahadevan
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 2.0.0, 1.2.3, 1.1.4
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> KafkaSpout internally maintains a waitingToEmit list per topic partition and keeps removing the first item to emit during each nextTuple. The implementation uses an ArrayList which results in un-necessary traversal and copy for each tuple.
> Also I am not sure why the nextTuple only emits a single tuple wheres ideally it should emit whatever it can emit in a single nextTuple call which is more efficient.  However the logic appears too complicated to refactor.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)