[GitHub] [spark] maropu commented on a change in pull request #30024: [SPARK-32229][SQL]Fix PostgresConnectionProvider and MSSQLConnectionProvider by accessing wrapped driver

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #30024:
URL: https://github.com/apache/spark/pull/30024#discussion_r504682836



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/MSSQLConnectionProvider.scala
##########
@@ -35,10 +35,12 @@ private[sql] class MSSQLConnectionProvider extends SecureConnectionProvider {
     val configName = "jaasConfigurationName"
     val appEntryDefault = "SQLJDBCDriver"
 
+    val wrappedDriver = DriverRegistry.getWrappedDriver(driver)

Review comment:
       We cannot move this unwrap code in the caller side `ConnectionProvider.create`? If this issue can happen only in mssql and pg, the current code looks okay. But, I'm not sure about if that is true. IMO it seems safer to always unwrap drivers.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org