You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/28 15:47:59 UTC

[GitHub] [tvm] ekalda commented on a diff in pull request #12856: [microTVM] Generalize depthwise_conv2d schedule

ekalda commented on code in PR #12856:
URL: https://github.com/apache/tvm/pull/12856#discussion_r982571089


##########
tests/python/relay/strategy/arm_cpu/test_depthwise_conv2d.py:
##########
@@ -165,9 +165,13 @@ class TestDepthwiseConv2d_NHWC_HWOI_DSP(BasicDepthwiseConv2dTests):
         ((1, 3, 3, 256), (3, 3), 256, (1, 1), 1, 1),
         # Asymmetric height and width
         ((1, 25, 5, 64), (3, 3), 64, (1, 1), 1, 1),
+        # Larger kernel
+        ((1, 24, 24, 8), (5, 5), 8, (1, 1), 1, 1),
+        # Asymmetric kernel
+        ((1, 24, 24, 8), (3, 5), 8, (1, 1), 1, 1),
     )

Review Comment:
   If we are relaxing the requirement of channels to be divisible by 4 for some cases, don't we want to test it as well? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org