You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2015/02/19 16:37:12 UTC

[jira] [Commented] (LUCENE-6261) TwoPhaseDocIdSetIterator.matches should be called at most once per doc ID

    [ https://issues.apache.org/jira/browse/LUCENE-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327637#comment-14327637 ] 

ASF subversion and git services commented on LUCENE-6261:
---------------------------------------------------------

Commit 1660912 from [~jpountz] in branch 'dev/trunk'
[ https://svn.apache.org/r1660912 ]

LUCENE-6261: TwoPhaseDocIdSetIterator.matches() should be called at most once per doc ID.

> TwoPhaseDocIdSetIterator.matches should be called at most once per doc ID
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-6261
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6261
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-6261.patch
>
>
> We did not document it but TwoPhaseDocIdSetIterator.matches should only be called once per doc ID. In some cases, running it twice might not work (eg. phrases since the positions would already be consumed when we try to call matches() on the second time) and in the general case it would be a performance bug if this method is called several times anyway.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org