[GitHub] [netbeans] YannLeCorse commented on a change in pull request #1335: [NETBEANS-2667] Manage JOptionPane border

[GitBox <gi...@apache.org>]

YannLeCorse commented on a change in pull request #1335: [NETBEANS-2667] Manage JOptionPane border
URL: https://github.com/apache/netbeans/pull/1335#discussion_r298455421
 
 

 ##########
 File path: platform/core.windows/src/org/netbeans/core/windows/services/NbPresenter.java
 ##########
 @@ -15,6 +15,9 @@
  * KIND, either express or implied.  See the License for the
  * specific language governing permissions and limitations
  * under the License.
+ *
+ * Contains a bug fix contributed by Experian. © Experian, 2019. Licensed under Apache 2.0.
 
 Review comment:
   Build failed because of that but I've asked to add it to comply the license. Happy to remove it if it's not needed.
   
   **Request I received**
   
   Notice changes needed
   Clauses 4(b) and (c) of the licence are the relevant clauses. 4(b) says:
    
   _“You must cause any modified files to carry prominent notices stating that You changed the files”_
    
   How we comply with this depends how the file is structured. If the notice for a piece of code is found at the start of that particular code, then it can be a simple notice:
    
   _Contains a bug fix contributed by Experian. © Experian, 2019. Licensed under Apache 2.0._
    
   If all the notices are together at the front of the file, then our notice will also need to describe the particular code we’ve fixed. This notice format would work:
    
   _NAME OF THE PARTICULAR CODE contains a bug fix contributed by Experian. © Experian, 2019. Licensed under Apache 2.0._
    
   4(c) says that we must retain all notices already present in the software. Hopefully more straightforward! Please let me know if you would like to discuss.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists