You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/02/19 01:45:56 UTC

[GitHub] sv2000 commented on a change in pull request #2556: GOBBLIN-684: Ensure buffered messages are flushed before close() in K…

sv2000 commented on a change in pull request #2556: GOBBLIN-684: Ensure buffered messages are flushed before close() in K…
URL: https://github.com/apache/incubator-gobblin/pull/2556#discussion_r257866178
 
 

 ##########
 File path: gobblin-modules/gobblin-kafka-08/src/main/java/org/apache/gobblin/metrics/kafka/KafkaKeyValueProducerPusher.java
 ##########
 @@ -47,6 +51,9 @@
   private final String topic;
   private final KafkaProducer<K, V> producer;
   private final Closer closer;
+  private final Queue<Future<RecordMetadata>> futures = new LinkedBlockingDeque<>();
 
 Review comment:
   Thanks! Added more comments to explain how to set the capacity for the buffer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services