You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/12/15 22:18:23 UTC

[GitHub] [beam] kw2542 commented on a change in pull request #13550: [BEAM-11458] Backport Samza Runner Changes

kw2542 commented on a change in pull request #13550:
URL: https://github.com/apache/beam/pull/13550#discussion_r543727825



##########
File path: runners/samza/src/main/java/org/apache/beam/runners/samza/adapter/UnboundedSourceSystem.java
##########
@@ -268,6 +269,7 @@ public void register(SystemStreamPartition ssp, String offset) {
       private final FnWithMetricsWrapper metricsWrapper;
 
       private volatile boolean running;
+      private volatile boolean maxWatermarkReached = false;

Review comment:
       I believe this is change added to support Nexmark. @Zhangyx39  can you comment more on this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org