[GitHub] [lucene-solr] diegoceccarelli commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)

[GitBox <gi...@apache.org>]

diegoceccarelli commented on issue #300: SOLR-11831: Skip second grouping step if group.limit is 1 (aka Las Vegas Patch)
URL: https://github.com/apache/lucene-solr/pull/300#issuecomment-473669645
 
 
   @cpoerschke Thanks!
   
   @cpoerschke @mjosephidou  I rebased the patch on top of the current master and applied @cpoerschke suggestions - precommit and unit tests succeeded. 
   
   One thing that I want to discuss and fix is the value of `numFound` for each group, at the moment is always 1 (I'm relying what written in the comments) - but in case of one shard or shards partitioned according to the grouping field, it might be possible to return the exact number. I would support that, what do you think?  at the same time, in case of multiple shards `numFound` will not be reliable, but `numFound` can't be disabled or requested, should we just write proper documentation for this behaviour? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org