svn propchange: r1608347 - svn:log

[jl...@apache.org]

Author: jleroux
Revision: 1608347
Modified property: svn:log

Modified: svn:log at Tue Jul  8 06:43:54 2014
------------------------------------------------------------------------------
--- svn:log (original)
+++ svn:log Tue Jul  8 06:43:54 2014
@@ -1 +1,33 @@
 Keeps in sync with OFBiz trunk HEAD
+
+A patch from Shi Jinghai for "Proposal: URL-Generation Changes (mostly for SEO reasons but not only)" https://issues.apache.org/jira/browse/OFBIZ-5312
+
+Fixes 3 bugs reported by Ingo Wolfmayr:
+after testing the seo branch if found the following problems (comparing actual seo branch vs. trunk with demo data):
+
+1) robots.txt - set in allowedPaths (web.xml)
+
+SeoContextFilter
+[java] requestInfo:
+[java] httpRequest.getServletPath():
+--> which results in a 404
+
+ContextFilter
+[java] requestInfo: /*
+[java] httpRequest.getServletPath(): /robots.txt
+
+2) When sending the "confirmation mail", the inluded urls (link to product, continue shopping) are missing the host information.
+
+3) webapp/src/org/ofbiz/webapp/WebAppUtil
+getControlServletPath has a if clause checking "org.ofbiz.webapp.control.ControlServlet".equals(servletDef.getServletClass())
+
+as it is null with "ecommerce web.xml" the getControlServletPath throws an Exception
+
+Confirmed by Jinghai:
+The test cases are:
+1. JSP files: /ecommerce/index.jsp, /ecommerce/error/404.jsp
+2. allowPaths: /ecommerce/images/blog.css, /ecommerce/robots.txt
+3. Original /products urls: /ecommerce/products/p_ENCHILADAS, /ecommerce/products/p_10000
+4. Place an order, check the product urls in Order Confirmation Notice email.
+
+