You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/09/24 20:35:16 UTC
[GitHub] [commons-collections] angusdev opened a new pull request, #340: COLLECTIONS-814 CollectionUtils.removeAll() not throwing NPE
angusdev opened a new pull request, #340:
URL: https://github.com/apache/commons-collections/pull/340
[COLLECTIONS-814](https://issues.apache.org/jira/browse/COLLECTIONS-814)
CollectionUtils.removeAll() not throwing proper NullPointerException(NPE) if the first parameter is empty
Add null check in ListUtil.removeAll()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] kinow closed pull request #340: COLLECTIONS-814 CollectionUtils.removeAll() not throwing NPE
Posted by GitBox <gi...@apache.org>.
kinow closed pull request #340: COLLECTIONS-814 CollectionUtils.removeAll() not throwing NPE
URL: https://github.com/apache/commons-collections/pull/340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] kinow commented on pull request #340: COLLECTIONS-814 CollectionUtils.removeAll() not throwing NPE
Posted by GitBox <gi...@apache.org>.
kinow commented on PR #340:
URL: https://github.com/apache/commons-collections/pull/340#issuecomment-1283291732
Merged. Thanks @angusdev !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] codecov-commenter commented on pull request #340: COLLECTIONS-814 CollectionUtils.removeAll() not throwing NPE
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #340:
URL: https://github.com/apache/commons-collections/pull/340#issuecomment-1257062009
# [Codecov](https://codecov.io/gh/apache/commons-collections/pull/340?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#340](https://codecov.io/gh/apache/commons-collections/pull/340?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a3490d3) into [master](https://codecov.io/gh/apache/commons-collections/commit/474713f727f49707a4ac77ed737d0205d22152ee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (474713f) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #340 +/- ##
============================================
+ Coverage 85.93% 85.98% +0.05%
- Complexity 4669 4671 +2
============================================
Files 289 289
Lines 13445 13447 +2
Branches 1977 1977
============================================
+ Hits 11554 11563 +9
+ Misses 1327 1323 -4
+ Partials 564 561 -3
```
| [Impacted Files](https://codecov.io/gh/apache/commons-collections/pull/340?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ava/org/apache/commons/collections4/ListUtils.java](https://codecov.io/gh/apache/commons-collections/pull/340/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L0xpc3RVdGlscy5qYXZh) | `87.30% <100.00%> (+0.20%)` | :arrow_up: |
| [...commons/collections4/map/AbstractReferenceMap.java](https://codecov.io/gh/apache/commons-collections/pull/340/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvY29sbGVjdGlvbnM0L21hcC9BYnN0cmFjdFJlZmVyZW5jZU1hcC5qYXZh) | `91.48% <0.00%> (+2.59%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-collections] angusdev commented on pull request #340: COLLECTIONS-814 CollectionUtils.removeAll() not throwing NPE
Posted by GitBox <gi...@apache.org>.
angusdev commented on PR #340:
URL: https://github.com/apache/commons-collections/pull/340#issuecomment-1281900818
ping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org