You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2013/11/27 03:21:02 UTC
Review Request 15869: HIVE-5895 vectorization handles division by zero
differently from normal execution
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
HIVE-5895 vectorization handles division by zero differently from normal execution
Diffs
-----
ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
ql/src/test/results/clientpositive/vectorization_short_regress.q.out c9296e1
Diff: https://reviews.apache.org/r/15869/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero
differently from normal execution
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/#review29471
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java
<https://reviews.apache.org/r/15869/#comment56702>
disregard this part of the comment (and below)
- Sergey Shelukhin
On Nov. 27, 2013, 2:20 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15869/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 2:20 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-5895 vectorization handles division by zero differently from normal execution
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
> ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_short_regress.q.out c9296e1
>
> Diff: https://reviews.apache.org/r/15869/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero
differently from normal execution
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Nov. 27, 2013, 7:02 p.m., Eric Hanson wrote:
> > ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt, line 73
> > <https://reviews.apache.org/r/15869/diff/1/?file=391378#file391378line73>
> >
> > you could simplify this to set the output to repeating and make it null, since all outputs will be null if value == 0
that's what I do if there's no selected in use; should it be done also w/selected?
> On Nov. 27, 2013, 7:02 p.m., Eric Hanson wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java, line 72
> > <https://reviews.apache.org/r/15869/diff/1/?file=391381#file391381line72>
> >
> > same thing -- output will be null and repeating so you can simplify
same as above
> On Nov. 27, 2013, 7:02 p.m., Eric Hanson wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java, line 101
> > <https://reviews.apache.org/r/15869/diff/1/?file=391380#file391380line101>
> >
> > I think the output will be always all nulls in this case so you can simplify it to always set output to repeating and null.
same as above
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/#review29493
-----------------------------------------------------------
On Nov. 27, 2013, 2:20 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15869/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 2:20 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-5895 vectorization handles division by zero differently from normal execution
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
> ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_short_regress.q.out c9296e1
>
> Diff: https://reviews.apache.org/r/15869/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero
differently from normal execution
Posted by Eric Hanson <eh...@microsoft.com>.
> On Nov. 27, 2013, 7:02 p.m., Eric Hanson wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java, line 101
> > <https://reviews.apache.org/r/15869/diff/1/?file=391380#file391380line101>
> >
> > I think the output will be always all nulls in this case so you can simplify it to always set output to repeating and null.
>
> Sergey Shelukhin wrote:
> same as above
see my comment on the above
> On Nov. 27, 2013, 7:02 p.m., Eric Hanson wrote:
> > ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt, line 73
> > <https://reviews.apache.org/r/15869/diff/1/?file=391378#file391378line73>
> >
> > you could simplify this to set the output to repeating and make it null, since all outputs will be null if value == 0
>
> Sergey Shelukhin wrote:
> that's what I do if there's no selected in use; should it be done also w/selected?
for col/value, when value (the scalar) is 0, all outputs will be null, so yes, you should make it isRepeating even if selected is in use
- Eric
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/#review29493
-----------------------------------------------------------
On Dec. 3, 2013, 9:44 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15869/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 9:44 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-5895 vectorization handles division by zero differently from normal execution
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 1b79401
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java 9de8461
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorScalarColArithmetic.java fa4da40
> ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_short_regress.q.out 18ff938
>
> Diff: https://reviews.apache.org/r/15869/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero
differently from normal execution
Posted by Eric Hanson <eh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/#review29493
-----------------------------------------------------------
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt
<https://reviews.apache.org/r/15869/#comment56790>
Please remove trailing white space in your new templates
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt
<https://reviews.apache.org/r/15869/#comment56791>
Fix comment to use correct file name
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt
<https://reviews.apache.org/r/15869/#comment56796>
correct file name in comment
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt
<https://reviews.apache.org/r/15869/#comment56795>
you could simplify this to set the output to repeating and make it null, since all outputs will be null if value == 0
ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt
<https://reviews.apache.org/r/15869/#comment56797>
correct file name in comment
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java
<https://reviews.apache.org/r/15869/#comment56800>
I think the output will be always all nulls in this case so you can simplify it to always set output to repeating and null.
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java
<https://reviews.apache.org/r/15869/#comment56801>
same thing -- output will be null and repeating so you can simplify
ql/src/test/queries/clientpositive/vectorization_div0.q
<https://reviews.apache.org/r/15869/#comment56811>
Please add a basic sanity check of / by 0 in the junit tests.
ql/src/test/queries/clientpositive/vectorization_div0.q
<https://reviews.apache.org/r/15869/#comment56809>
I tried this and it does not vectorize. Need to make sure all the queries vectorize. Consider using explain in the .q test as well to record that the query is vectorized.
ql/src/test/queries/clientpositive/vectorization_div0.q
<https://reviews.apache.org/r/15869/#comment56810>
COALESCE does not vectorize yet
- Eric Hanson
On Nov. 27, 2013, 2:20 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15869/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 2:20 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-5895 vectorization handles division by zero differently from normal execution
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
> ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_short_regress.q.out c9296e1
>
> Diff: https://reviews.apache.org/r/15869/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero
differently from normal execution
Posted by Sergey Shelukhin <se...@hortonworks.com>.
On Dec. 2, 2013, 10:55 p.m., Sergey Shelukhin wrote:
> > I did not see the junit test. I also see trailing white space in template files still. Did you upload latest diff to ReviewBoard?
> >
not yet, working on q file
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/#review29625
-----------------------------------------------------------
On Nov. 27, 2013, 2:20 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15869/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 2:20 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-5895 vectorization handles division by zero differently from normal execution
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
> ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_short_regress.q.out c9296e1
>
> Diff: https://reviews.apache.org/r/15869/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero
differently from normal execution
Posted by Eric Hanson <eh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/#review29625
-----------------------------------------------------------
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt
<https://reviews.apache.org/r/15869/#comment57037>
I think you can because the output will be repeating either way. The code you have works correctly. This is a minor performance optimization and simplification.
I did not see the junit test. I also see trailing white space in template files still. Did you upload latest diff to ReviewBoard?
- Eric Hanson
On Nov. 27, 2013, 2:20 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15869/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2013, 2:20 a.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-5895 vectorization handles division by zero differently from normal execution
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
> ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_short_regress.q.out c9296e1
>
> Diff: https://reviews.apache.org/r/15869/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero
differently from normal execution
Posted by Eric Hanson <eh...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/#review29685
-----------------------------------------------------------
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorScalarColArithmetic.java
<https://reviews.apache.org/r/15869/#comment57122>
need to assert out.noNulls is false after evaluate. Otherwise, isNull array contents are undefined.
- Eric Hanson
On Dec. 3, 2013, 9:44 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15869/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2013, 9:44 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-5895 vectorization handles division by zero differently from normal execution
>
>
> Diffs
> -----
>
> ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
> ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 1b79401
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java 9de8461
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorScalarColArithmetic.java fa4da40
> ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
> ql/src/test/results/clientpositive/vectorization_short_regress.q.out 18ff938
>
> Diff: https://reviews.apache.org/r/15869/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero
differently from normal execution
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/
-----------------------------------------------------------
(Updated Dec. 3, 2013, 11:24 p.m.)
Review request for hive.
Repository: hive-git
Description
-------
HIVE-5895 vectorization handles division by zero differently from normal execution
Diffs (updated)
-----
ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 1b79401
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java 9de8461
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorScalarColArithmetic.java fa4da40
ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 18ff938
Diff: https://reviews.apache.org/r/15869/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero
differently from normal execution
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/
-----------------------------------------------------------
(Updated Dec. 3, 2013, 9:44 p.m.)
Review request for hive.
Repository: hive-git
Description
-------
HIVE-5895 vectorization handles division by zero differently from normal execution
Diffs (updated)
-----
ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 1b79401
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java 9de8461
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorScalarColArithmetic.java fa4da40
ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 18ff938
Diff: https://reviews.apache.org/r/15869/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 15869: HIVE-5895 vectorization handles division by zero
differently from normal execution
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/
-----------------------------------------------------------
(Updated Dec. 3, 2013, 2:06 a.m.)
Review request for hive.
Repository: hive-git
Description
-------
HIVE-5895 vectorization handles division by zero differently from normal execution
Diffs (updated)
-----
ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION
ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION
ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 1b79401
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java 9de8461
ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION
ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION
ql/src/test/results/clientpositive/vectorization_short_regress.q.out 18ff938
Diff: https://reviews.apache.org/r/15869/diff/
Testing
-------
Thanks,
Sergey Shelukhin