You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2022/06/03 13:44:00 UTC

[GitHub] [curator] lacinoire commented on pull request #418: (test) Add test for InstanceSpec. and .getQuorumPort

lacinoire commented on PR #418:
URL: https://github.com/apache/curator/pull/418#issuecomment-1145980560

   Good point regarding the getter method.
   I still proposed the test case because it also covers new instructions in the constructor of [InstanceSpec](https://github.com/apache/curator/blob/a5b24b8b5d954aea17fc0b1a50d23bb460482658/curator-test/src/main/java/org/apache/curator/test/InstanceSpec.java#L175) (setting the quorum port to the passed value if it is larger than 0).
   
   Do you find it meaningful to test (this kind of) constructor?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org