[GitHub] DaanHoogland commented on a change in pull request #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #2408: CLOUDSTACK-10231: Detach ISO fails for direct downloaded ISO on KVM
URL: https://github.com/apache/cloudstack/pull/2408#discussion_r164081245
 
 

 ##########
 File path: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
 ##########
 @@ -1125,11 +1106,34 @@ public Answer dettachIso(final DettachCommand cmd) {
             return new Answer(cmd, false, e.toString());
         } catch (final InternalErrorException e) {
             return new Answer(cmd, false, e.toString());
+        } catch (final InvalidParameterValueException e) {
+            return new Answer(cmd, false, e.toString());
         }
 
         return new Answer(cmd);
     }
 
+    /**
+     * Return data store URL from store
+     */
+    private String getDataStoreUrlFromStore(DataStoreTO store) {
+        if (!(store instanceof NfsTO) && (!(store instanceof PrimaryDataStoreTO) ||
 
 Review comment:
   java could really do with an unless construct here ;)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services