[GitHub] [metron] sardell opened a new pull request #1513: METRON-2257: Metron-Alerts GUI testing failing on MacOS builds

[GitBox <gi...@apache.org>]

sardell opened a new pull request #1513: METRON-2257: Metron-Alerts GUI testing failing on MacOS builds
URL: https://github.com/apache/metron/pull/1513
 
 
   ## Contributor Comments
   This PR resolves a regression introduced in the dependency upgrades in [METRON-2243](https://github.com/apache/metron/commit/edc449ffa6be51749f6a3b100bf6a0a33755e50c) (Thanks for catching this, @tigerquoll!)
   
   I haven't quite identified the 'why' to this bug, but it looks like Cypress' update to use Electron 61 in release 3.3.0 is causing some issues with Cypress' click functionality. See the below gif, which is a recording of tests being run in Electron 61. You can see in the test side panel that the PCAP link was successfully clicked, but the route never changes. The error complains about an xhr request that was never detected because we never made it to the PCAP page which fires the request. The failures are random and differ from test run to test run, but in every video I captured the cause shows to stem from the route never changing after clicking the PCAP link.
   
   ![cypress-failure](https://user-images.githubusercontent.com/7304869/64974548-47f9b600-d8ad-11e9-8ced-505d639dd8cd.gif)
   
   I reverted Cypress to release 3.2.0, which unfortunately introduces a high-vulnerability nested dependency. I'm going to try to update that dependency tomorrow, but for now I wanted to open a draft for others to test against.
   
   ## Testing
   NOTE: We've only detected this on macOS, so you'll need that to test.
   
   From the root of the project, run `mvn install -pl :metron-alerts`. If testing on master, it will fail with random Cypress failures. If running on this branch, everything should pass as it should.
   
   ## Pull Request Checklist
   
   Thank you for submitting a contribution to Apache Metron.  
   Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
   Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
   
   
   In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
   - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
   
   
   ### For code changes:
   - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
   - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
   - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
     ```
     mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
     ```
   
   - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
   
     ```
     cd site-book
     mvn site
     ```
   
   - [ ] Have you ensured that any documentation diagrams have been updated, along with their source files, using [draw.io](https://www.draw.io/)? See [Metron Development Guidelines](https://cwiki.apache.org/confluence/display/METRON/Development+Guidelines) for instructions.
   
   #### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
   It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services