You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/05/14 10:42:14 UTC

Re: Review Request 70295: Enabled launcher sealing for RPM packages.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70295/#review215247
-----------------------------------------------------------


Ship it!




Since Benjamin doesn't have time to finish this review, I went ahead and committed it including the changes proposed by @jdef.

- Benno Evers


On March 25, 2019, 3:09 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70295/
> -----------------------------------------------------------
> 
> (Updated March 25, 2019, 3:09 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-9677
>     https://issues.apache.org/jira/browse/MESOS-9677
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We enable this flag since with it disabled certain public functions
> are not available making it hard to e.g., write modules against this
> version of Mesos.
> 
> While launcher sealing depends on a recent kernel, the platform we
> build RPMs for already satisfies the requirements.
> 
> 
> Diffs
> -----
> 
>   support/packaging/centos/mesos.spec de905fda3366be5904a0aec8249abcc53b0af9a0 
> 
> 
> Diff: https://reviews.apache.org/r/70295/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>