[GitHub] [airflow] ashb commented on a change in pull request #5111: [AIRFLOW-4294] fix missing dag & task runs in UI when . in dag_id

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5111: [AIRFLOW-4294] fix missing dag & task runs in UI when . in dag_id
URL: https://github.com/apache/airflow/pull/5111#discussion_r275880566
 
 

 ##########
 File path: airflow/www/templates/airflow/dags.html
 ##########
 @@ -312,7 +312,7 @@ <h2>DAGs</h2>
       d3.json("{{ url_for('Airflow.dag_stats') }}", function(error, json) {
         for(var dag_id in json) {
             states = json[dag_id];
-            g = d3.select('svg#dag-run-' + dag_id)
+            g = d3.select('svg#dag-run-' + dag_id.replace(/\./g, '__dot__'))
 
 Review comment:
   I wonder if the better fix is to change how the JSON is generated to use the `dag.safe_dag_id` accessor instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services