You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2015/05/27 01:44:37 UTC

[GitHub] couchdb-fauxton pull request: Databases component fix

GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/440

    Databases component fix

    This fixes a small problem with the mocha test for the databases
    component. Because it didn't reset the store it would sometimes
    interfere with other mocha tests running. Only seen with the dash.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton databases-component-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/440.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #440
    
----
commit 0e34b78c4b2de756d3dd60d3a135024039fe622a
Author: Ben Keen <be...@gmail.com>
Date:   2015-05-26T17:50:31Z

    Prevent duplicate mocha tests running
    
    When running mocha for environments where Fauxton has been
    extended, e.g. the Cloudant dashboard, tests unique to that other
    environment get run twice because the original tests are included
    once from the original folder and once from where they've been
    copied - in the Fauxton /app folder. Since we know that the files
    would need to be copied over to the /app folder for inclusion
    in Fauxton, this PR removes the extra tests from the original
    source.

commit f4018a8aa87d6ef284ae221aa92147d8b20837f3
Author: Ben Keen <be...@gmail.com>
Date:   2015-05-26T22:48:11Z

    Databases component and test fixes
    
    This fixes a small problem with the mocha test for the databases
    component. Because it didn't reset the store it would sometimes
    interfere with other mocha tests running. Only seen with the dash.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Databases component fix

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/440#discussion_r31134262
  
    --- Diff: tasks/fauxton.js ---
    @@ -116,6 +116,12 @@ module.exports = function (grunt) {
         var fileSrc = grunt.option('file') || data.files.src;
         var testFiles =  grunt.file.expand(fileSrc);
     
    +    // filter out any tests that aren't found in the /app/ folder. For scripts that are extending Fauxton, we still
    +    // know that all addons will have been copied into /app. This prevent tests being ran twice
    +    testFiles = _.filter(testFiles, function (filePath) {
    +      return /\/app\//.test(filePath);
    +    });
    +
    --- End diff --
    
    we also have unit tests in `core`
    
    how about blcklisting the dist folder?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Databases component fix

Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/440


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Databases component fix

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/440#issuecomment-105981443
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Databases component fix

Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on a diff in the pull request:

    https://github.com/apache/couchdb-fauxton/pull/440#discussion_r31139219
  
    --- Diff: tasks/fauxton.js ---
    @@ -116,6 +116,12 @@ module.exports = function (grunt) {
         var fileSrc = grunt.option('file') || data.files.src;
         var testFiles =  grunt.file.expand(fileSrc);
     
    +    // filter out any tests that aren't found in the /app/ folder. For scripts that are extending Fauxton, we still
    +    // know that all addons will have been copied into /app. This prevent tests being ran twice
    +    testFiles = _.filter(testFiles, function (filePath) {
    +      return /\/app\//.test(filePath);
    +    });
    +
    --- End diff --
    
    The duplicates were actually relative links in `dashboard/`, not dist; checking for `app/` (i.e. a folder in Fauxton) is the only appropriate way, I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Databases component fix

Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/440#issuecomment-105984940
  
    Merged as 1739a8e


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---