You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2015/03/25 01:02:11 UTC
[02/12] mesos git commit: Updated the http-parser upgrade TODO.
Updated the http-parser upgrade TODO.
Review: https://reviews.apache.org/r/32342
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/2622b015
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/2622b015
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/2622b015
Branch: refs/heads/master
Commit: 2622b0153ec9e5895e8c5fe0e5a0c53e5863cd72
Parents: 39426df
Author: Benjamin Mahler <be...@gmail.com>
Authored: Fri Mar 20 11:58:27 2015 -0700
Committer: Benjamin Mahler <be...@gmail.com>
Committed: Tue Mar 24 16:47:18 2015 -0700
----------------------------------------------------------------------
3rdparty/libprocess/src/decoder.hpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/2622b015/3rdparty/libprocess/src/decoder.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/decoder.hpp b/3rdparty/libprocess/src/decoder.hpp
index 45f3d7f..25b0228 100644
--- a/3rdparty/libprocess/src/decoder.hpp
+++ b/3rdparty/libprocess/src/decoder.hpp
@@ -15,7 +15,9 @@
#include <stout/try.hpp>
-// TODO(bmahler): Upgrade our http_parser to the latest version.
+// TODO(bmahler): Switch to joyent/http-parser now that it is no
+// longer being hosted under ry/http-parser.
+
namespace process {
// TODO(benh): Make DataDecoder abstract and make RequestDecoder a
@@ -50,6 +52,7 @@ public:
size_t parsed = http_parser_execute(&parser, &settings, data, length);
if (parsed != length) {
+ // TODO(bmahler): joyent/http-parser exposes error reasons.
failure = true;
}
@@ -296,6 +299,7 @@ public:
size_t parsed = http_parser_execute(&parser, &settings, data, length);
if (parsed != length) {
+ // TODO(bmahler): joyent/http-parser exposes error reasons.
failure = true;
}