You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by "Karl Tauber (Jira)" <ji...@apache.org> on 2020/03/17 16:26:00 UTC
[jira] [Commented] (NETBEANS-3792) Hardcoded colors for "Remove
Surrounding Code" action
[ https://issues.apache.org/jira/browse/NETBEANS-3792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061038#comment-17061038 ]
Karl Tauber commented on NETBEANS-3792:
---------------------------------------
The PR is merged. Can we close this issue?
> Hardcoded colors for "Remove Surrounding Code" action
> -----------------------------------------------------
>
> Key: NETBEANS-3792
> URL: https://issues.apache.org/jira/browse/NETBEANS-3792
> Project: NetBeans
> Issue Type: Bug
> Components: editor - Painting & Printing, ide - UI
> Affects Versions: 11.2
> Reporter: Alessandro Falappa
> Priority: Minor
> Labels: pull-request-available
> Attachments: remove-surrounding-on-darktheme.png
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The RemoveSurroundingCode action contains hardcoded colors here:
> [https://github.com/apache/netbeans/blob/accdbada0a9c5105bd3f06e435024230c1618316/java/java.editor/src/org/netbeans/modules/java/editor/codegen/RemoveSurroundingCodeAction.java#L215]
> The choosen colors look too bright on dark themes. The colors should be taken from the LAF's defaults or better exposed in the editor color profile and made customizable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists