You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/10/26 08:22:24 UTC

[GitHub] [ignite] AMashenkov commented on a change in pull request #9392: IGNITE-15289 Global statistics collection

AMashenkov commented on a change in pull request #9392:
URL: https://github.com/apache/ignite/pull/9392#discussion_r736277549



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/query/stat/config/StatisticsObjectConfiguration.java
##########
@@ -243,6 +242,37 @@ public byte maxPartitionObsolescencePercent() {
         return S.toString(StatisticsObjectConfiguration.class, this);
     }
 
+    /**
+     * Compare only configuration from the same branch. I.e. can't correctly compare
+     * Cfg(A=v1,B=v3) vs Cfg(A=v2,B=v1)
+     * Cfg(A=v1,B=v3) vs Cfg(A=v1m C=v2)

Review comment:
       ```suggestion
        * Cfg(A=v1,B=v3) vs Cfg(A=v1, C=v2)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org