You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Alexey Goncharuk <al...@gmail.com> on 2020/01/21 13:01:00 UTC
Request for review: @IgniteExperimental
Igniters,
As discussed in the thread [1], we want to add an annotation marking an API
or feature experimental. The corresponding ticket and PR are [2],[3].
Please take a look at the description and suggest any edits to the javadoc
if necessary.
A side question - Anton Vinogradov asked me to mark the read-repair
feature as experimental in this PR. Should I also mark the IEP-35
interfaces there as well or should we move that change to a separate ticket?
[1]
http://apache-ignite-developers.2346864.n4.nabble.com/Internal-classes-are-exposed-in-public-API-td45146.html
[2] https://issues.apache.org/jira/browse/IGNITE-12559
[3] https://github.com/apache/ignite/pull/7279
Re: Request for review: @IgniteExperimental
Posted by Anton Vinogradov <av...@apache.org>.
Great, Thanks!
On Fri, Jan 24, 2020 at 1:14 PM Alexey Goncharuk <al...@gmail.com>
wrote:
> Thanks to all for the review, the annotation has been added, also created
> an additional ticket for documentation.
>
> вт, 21 янв. 2020 г. в 16:23, Alexey Goncharuk <alexey.goncharuk@gmail.com
> >:
>
> > Pavel, Igor,
> >
> > Can you add similar annotations/attributes to platforms?
> >
> > вт, 21 янв. 2020 г. в 16:01, Alexey Goncharuk <
> alexey.goncharuk@gmail.com
> > >:
> >
> >> Igniters,
> >>
> >> As discussed in the thread [1], we want to add an annotation marking an
> >> API or feature experimental. The corresponding ticket and PR are
> [2],[3].
> >>
> >> Please take a look at the description and suggest any edits to the
> >> javadoc if necessary.
> >>
> >> A side question - Anton Vinogradov asked me to mark the read-repair
> >> feature as experimental in this PR. Should I also mark the IEP-35
> >> interfaces there as well or should we move that change to a separate
> ticket?
> >>
> >> [1]
> >>
> http://apache-ignite-developers.2346864.n4.nabble.com/Internal-classes-are-exposed-in-public-API-td45146.html
> >> [2] https://issues.apache.org/jira/browse/IGNITE-12559
> >> [3] https://github.com/apache/ignite/pull/7279
> >>
> >
>
Re: Request for review: @IgniteExperimental
Posted by Alexey Goncharuk <al...@gmail.com>.
Thanks to all for the review, the annotation has been added, also created
an additional ticket for documentation.
вт, 21 янв. 2020 г. в 16:23, Alexey Goncharuk <al...@gmail.com>:
> Pavel, Igor,
>
> Can you add similar annotations/attributes to platforms?
>
> вт, 21 янв. 2020 г. в 16:01, Alexey Goncharuk <alexey.goncharuk@gmail.com
> >:
>
>> Igniters,
>>
>> As discussed in the thread [1], we want to add an annotation marking an
>> API or feature experimental. The corresponding ticket and PR are [2],[3].
>>
>> Please take a look at the description and suggest any edits to the
>> javadoc if necessary.
>>
>> A side question - Anton Vinogradov asked me to mark the read-repair
>> feature as experimental in this PR. Should I also mark the IEP-35
>> interfaces there as well or should we move that change to a separate ticket?
>>
>> [1]
>> http://apache-ignite-developers.2346864.n4.nabble.com/Internal-classes-are-exposed-in-public-API-td45146.html
>> [2] https://issues.apache.org/jira/browse/IGNITE-12559
>> [3] https://github.com/apache/ignite/pull/7279
>>
>
Re: Request for review: @IgniteExperimental
Posted by Alexey Goncharuk <al...@gmail.com>.
Pavel, Igor,
Can you add similar annotations/attributes to platforms?
вт, 21 янв. 2020 г. в 16:01, Alexey Goncharuk <al...@gmail.com>:
> Igniters,
>
> As discussed in the thread [1], we want to add an annotation marking an
> API or feature experimental. The corresponding ticket and PR are [2],[3].
>
> Please take a look at the description and suggest any edits to the javadoc
> if necessary.
>
> A side question - Anton Vinogradov asked me to mark the read-repair
> feature as experimental in this PR. Should I also mark the IEP-35
> interfaces there as well or should we move that change to a separate ticket?
>
> [1]
> http://apache-ignite-developers.2346864.n4.nabble.com/Internal-classes-are-exposed-in-public-API-td45146.html
> [2] https://issues.apache.org/jira/browse/IGNITE-12559
> [3] https://github.com/apache/ignite/pull/7279
>