You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rluvaton (via GitHub)" <gi...@apache.org> on 2025/02/04 10:05:38 UTC

[PR] feat: add `new_unchecked` method for `RecordBatch` [arrow-rs]

rluvaton opened a new pull request, #7072:
URL: https://github.com/apache/arrow-rs/pull/7072

   # Which issue does this PR close?
   
   Closes #7071
   
   # Rationale for this change
    
   See linked issue
   
   # What changes are included in this PR?
   
   Added `new_unchecked` method for `RecordBatch` and changed all internal calls to use it
   
   # Are there any user-facing changes?
   
   new function on record batch
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: add `new_unchecked` method for `RecordBatch` [arrow-rs]

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #7072:
URL: https://github.com/apache/arrow-rs/pull/7072#issuecomment-2633634097

   I'll comment on the issue, but if this is a bottleneck in your code it indicates a fairly major code smell. The cost of creating RecordBatch/arrays should be amortised over thousands of rows.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: add `new_unchecked` method for `RecordBatch` [arrow-rs]

Posted by "rluvaton (via GitHub)" <gi...@apache.org>.
rluvaton closed pull request #7072: feat: add `new_unchecked` method for `RecordBatch`
URL: https://github.com/apache/arrow-rs/pull/7072


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] feat: add `new_unchecked` method for `RecordBatch` [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7072:
URL: https://github.com/apache/arrow-rs/pull/7072#issuecomment-2640535360

   Looks like there is an alternate approach described in https://github.com/apache/arrow-rs/issues/7071#issuecomment-2633867717 so marking this one as draft .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org