You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/07/05 22:31:32 UTC

Re: Review Request 59759: Added protobuf definitions for fault domains.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59759/
-----------------------------------------------------------

(Updated July 5, 2017, 10:31 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Rebase.


Bugs: MESOS-7608
    https://issues.apache.org/jira/browse/MESOS-7608


Repository: mesos


Description
-------

This introduces a first-class notion of a "domain", which is a set of
hosts that have similar characteristics. Mesos will initially only
support "fault domains", which identify groups of hosts with similar
failure characteristics.


Diffs (updated)
-----

  include/mesos/mesos.proto 4e4b2790615e8bbbf262ba809cbfd67e24368952 
  include/mesos/type_utils.hpp d2a6591b65b95b4e37e6a87dd3b11377834daf85 
  include/mesos/v1/mesos.hpp 2479b004f342ffcb05279e3b12b6de6949190a93 
  include/mesos/v1/mesos.proto b8625d363388bc707bc2458abd47a218cc7b7888 
  src/common/type_utils.cpp aeb16238e9c3fd71a8e9e57dbb8098ddc004e1f2 
  src/v1/mesos.cpp 423510ef14025dba208ef85edf5305c2ce58f01d 


Diff: https://reviews.apache.org/r/59759/diff/2/

Changes: https://reviews.apache.org/r/59759/diff/1-2/


Testing
-------

`make check`


Thanks,

Neil Conway


Re: Review Request 59759: Added protobuf definitions for fault domains.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59759/#review179715
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On July 5, 2017, 10:31 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59759/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 10:31 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7608
>     https://issues.apache.org/jira/browse/MESOS-7608
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This introduces a first-class notion of a "domain", which is a set of
> hosts that have similar characteristics. Mesos will initially only
> support "fault domains", which identify groups of hosts with similar
> failure characteristics.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 4e4b2790615e8bbbf262ba809cbfd67e24368952 
>   include/mesos/type_utils.hpp d2a6591b65b95b4e37e6a87dd3b11377834daf85 
>   include/mesos/v1/mesos.hpp 2479b004f342ffcb05279e3b12b6de6949190a93 
>   include/mesos/v1/mesos.proto b8625d363388bc707bc2458abd47a218cc7b7888 
>   src/common/type_utils.cpp aeb16238e9c3fd71a8e9e57dbb8098ddc004e1f2 
>   src/v1/mesos.cpp 423510ef14025dba208ef85edf5305c2ce58f01d 
> 
> 
> Diff: https://reviews.apache.org/r/59759/diff/2/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>