You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/10 19:00:36 UTC
[GitHub] [superset] krsnik93 opened a new pull request #14072: [WIP] add Echarts gauge chart
krsnik93 opened a new pull request #14072:
URL: https://github.com/apache/superset/pull/14072
### SUMMARY
Add Echarts gauge chart
PR from superset-ui: https://github.com/apache-superset/superset-ui/pull/993
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (92fb380) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.93%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 78.36% -0.94%
==========================================
Files 939 939
Lines 47541 47540 -1
Branches 5938 5938
==========================================
- Hits 37703 37256 -447
- Misses 9717 10133 +416
- Partials 121 151 +30
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.67% <ø> (-1.57%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| ... and [72 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...92fb380](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-820897797
@junlincc @krsnik93 I think we should try to get this fix in to ECharts, as I don't expect making that change should be very difficult. Let's open a ticket on the their GH Issues and see how the project feels about the proposed change of rendering the label outwards rather than inwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (f78d52e) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
> :exclamation: Current head f78d52e differs from pull request most recent head a00e48b. Consider uploading reports for the commit a00e48b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.01% -0.30%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37563 -140
- Misses 9717 9836 +119
- Partials 121 142 +21
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.28% <ø> (-0.95%)` | :arrow_down: |
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `59.25% <0.00%> (-40.75%)` | :arrow_down: |
| ... and [48 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...a00e48b](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 merged pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #14072:
URL: https://github.com/apache/superset/pull/14072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (f4f7272) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **increase** coverage by `0.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
+ Coverage 79.30% 79.55% +0.24%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
+ Hits 37703 37819 +116
+ Misses 9717 9601 -116
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (+1.82%)` | :arrow_up: |
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `90.05% <0.00%> (+4.09%)` | :arrow_up: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `86.66% <0.00%> (+6.66%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `82.05% <0.00%> (+7.69%)` | :arrow_up: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `90.90% <0.00%> (+8.08%)` | :arrow_up: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `58.93% <0.00%> (+9.66%)` | :arrow_up: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `100.00% <0.00%> (+11.11%)` | :arrow_up: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <0.00%> (+11.11%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...f4f7272](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (0f8f8f1) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `1.19%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 0f8f8f1 differs from pull request most recent head d1cefaf. Consider uploading reports for the commit d1cefaf to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 78.11% -1.20%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37136 -567
- Misses 9717 10257 +540
- Partials 121 148 +27
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `45.29% <ø> (-8.94%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.49%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset-frontend/src/dataMask/actions.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL2FjdGlvbnMudHM=) | `33.33% <0.00%> (-46.67%)` | :arrow_down: |
| ... and [73 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...d1cefaf](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (a00e48b) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.09% -0.22%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37601 -102
- Misses 9717 9803 +86
- Partials 121 137 +16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.02% <ø> (-1.22%)` | :arrow_down: |
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `71.66% <0.00%> (-23.34%)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...a00e48b](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #14072:
URL: https://github.com/apache/superset/pull/14072#discussion_r613534584
##########
File path: superset-frontend/src/visualizations/presets/MainPreset.js
##########
@@ -91,6 +92,7 @@ export default class MainPreset extends Preset {
new EventFlowChartPlugin().configure({ key: 'event_flow' }),
new FilterBoxChartPlugin().configure({ key: 'filter_box' }),
new EchartsGraphChartPlugin().configure({ key: 'graph_chart' }),
+ new EchartsGaugeChartPlugin().configure({ key: 'gauge_chart' }),
Review comment:
This chart type should probably be renamed to "gauge".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (20d87e5) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 20d87e5 differs from pull request most recent head 92fb380. Consider uploading reports for the commit 92fb380 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.28% -0.03%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37691 -12
- Misses 9717 9724 +7
- Partials 121 126 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.95% <ø> (-0.29%)` | :arrow_down: |
| javascript | `69.41% <ø> (ø)` | |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `58.49% <0.00%> (-15.10%)` | :arrow_down: |
| [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | `54.28% <0.00%> (-14.29%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `58.08% <0.00%> (-8.83%)` | :arrow_down: |
| [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | `92.30% <0.00%> (-7.70%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `73.17% <0.00%> (-7.32%)` | :arrow_down: |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `78.57% <0.00%> (-7.15%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...92fb380](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (a00e48b) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a00e48b differs from pull request most recent head 97479e6. Consider uploading reports for the commit 97479e6 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.09% -0.22%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37601 -102
- Misses 9717 9803 +86
- Partials 121 137 +16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.02% <ø> (-1.22%)` | :arrow_down: |
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `71.66% <0.00%> (-23.34%)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...97479e6](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (92fb380) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.26% -0.04%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37684 -19
- Misses 9717 9725 +8
- Partials 121 132 +11
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.48% <ø> (+0.24%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `65.38% <0.00%> (-19.24%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...92fb380](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-819720572
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-820955767
@krsnik93 ok now I understand 👍 In that case it could actually make sense to add an option to draw on the inside (default) or outside, with the assumption that outside will render outwards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (ea484b3) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.27%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ea484b3 differs from pull request most recent head 2f72380. Consider uploading reports for the commit 2f72380 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.03% -0.28%
==========================================
Files 939 939
Lines 47541 47542 +1
Branches 5938 5938
==========================================
- Hits 37703 37573 -130
- Misses 9717 9836 +119
- Partials 121 133 +12
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.46% <ø> (-1.78%)` | :arrow_down: |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `47.16% <0.00%> (-33.97%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `71.66% <0.00%> (-23.34%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `47.79% <0.00%> (-19.12%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `49.29% <0.00%> (-16.91%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `54.96% <0.00%> (-13.91%)` | :arrow_down: |
| ... and [44 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...2f72380](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (843d920) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 843d920 differs from pull request most recent head a00e48b. Consider uploading reports for the commit a00e48b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
+ Coverage 79.30% 79.35% +0.04%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
+ Hits 37703 37726 +23
+ Misses 9717 9691 -26
- Partials 121 124 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.80% <ø> (+0.56%)` | :arrow_up: |
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `59.25% <0.00%> (-40.75%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `70.68% <0.00%> (-15.52%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `57.14% <0.00%> (-7.15%)` | :arrow_down: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `33.33% <0.00%> (-2.90%)` | :arrow_down: |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `97.43% <0.00%> (-1.29%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `79.74% <0.00%> (-1.27%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `83.72% <0.00%> (-0.78%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...a00e48b](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (843d920) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.60%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 843d920 differs from pull request most recent head d68ce15. Consider uploading reports for the commit d68ce15 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 78.69% -0.61%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37414 -289
- Misses 9717 9982 +265
- Partials 121 145 +24
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.08% <ø> (+0.85%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| ... and [60 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...d68ce15](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (20d87e5) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 20d87e5 differs from pull request most recent head 8b0faae. Consider uploading reports for the commit 8b0faae to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.27% -0.03%
==========================================
Files 939 939
Lines 47541 47542 +1
Branches 5938 5938
==========================================
- Hits 37703 37691 -12
- Misses 9717 9725 +8
- Partials 121 126 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.95% <ø> (-0.29%)` | :arrow_down: |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `58.49% <0.00%> (-15.10%)` | :arrow_down: |
| [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | `54.28% <0.00%> (-14.29%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `58.08% <0.00%> (-8.83%)` | :arrow_down: |
| [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | `92.30% <0.00%> (-7.70%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `73.17% <0.00%> (-7.32%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...8b0faae](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (5281767) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `1.06%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 5281767 differs from pull request most recent head d1cefaf. Consider uploading reports for the commit d1cefaf to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 78.24% -1.07%
==========================================
Files 939 939
Lines 47541 47540 -1
Branches 5938 5938
==========================================
- Hits 37703 37197 -506
- Misses 9717 10201 +484
- Partials 121 142 +21
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.60% <ø> (-2.64%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.49%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
| ... and [88 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...d1cefaf](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (0f8f8f1) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.44%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 0f8f8f1 differs from pull request most recent head d1cefaf. Consider uploading reports for the commit d1cefaf to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 78.85% -0.45%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37490 -213
- Misses 9717 9919 +202
- Partials 121 132 +11
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.64% <ø> (-2.59%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.49%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
| [superset-frontend/src/dataMask/actions.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL2FjdGlvbnMudHM=) | `33.33% <0.00%> (-46.67%)` | :arrow_down: |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `34.24% <0.00%> (-46.58%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| ... and [51 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...d1cefaf](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (0e593d9) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 0e593d9 differs from pull request most recent head 1fe8e89. Consider uploading reports for the commit 1fe8e89 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.30% -0.01%
==========================================
Files 939 939
Lines 47541 47542 +1
Branches 5938 5938
==========================================
Hits 37703 37703
- Misses 9717 9718 +1
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...1fe8e89](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (92fb380) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 92fb380 differs from pull request most recent head 2f72380. Consider uploading reports for the commit 2f72380 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.26% -0.04%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37684 -19
- Misses 9717 9725 +8
- Partials 121 132 +11
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.48% <ø> (+0.24%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `65.38% <0.00%> (-19.24%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...2f72380](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] krsnik93 commented on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
krsnik93 commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-820953770
@villebro I had a look at the Echarts examples for gauge and I think they go inwards because the labels and ticks are originally placed on the inner side of the axis:
https://echarts.apache.org/examples/en/editor.html?c=gauge
https://echarts.apache.org/examples/en/editor.html?c=gauge-speed
When I was making the gauge plugin for Superset, I thought that having labels inwards would make them overlap more easily or overlap the value in the middle, so I applied a negative distance to have them on the outer side of the axis as here:
https://echarts.apache.org/examples/en/editor.html?c=gauge-temperature
So I think it's expected behavior from Echarts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (a00e48b) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
> :exclamation: Current head a00e48b differs from pull request most recent head d1cefaf. Consider uploading reports for the commit d1cefaf to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.09% -0.22%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37601 -102
- Misses 9717 9803 +86
- Partials 121 137 +16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.02% <ø> (-1.22%)` | :arrow_down: |
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `71.66% <0.00%> (-23.34%)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...d1cefaf](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817981883
@krsnik93 no need to update the visualizations.png file, i only meant to add a screenshot to the PR summary to verify it looks good. Although if we don't have a thumbnail in the viz selector yet, adding one there is a great idea too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (92fb380) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 92fb380 differs from pull request most recent head 2f72380. Consider uploading reports for the commit 2f72380 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.26% -0.04%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37684 -19
- Misses 9717 9725 +8
- Partials 121 132 +11
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.48% <ø> (+0.24%)` | :arrow_up: |
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `65.38% <0.00%> (-19.24%)` | :arrow_down: |
| ... and [29 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...2f72380](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (ea484b3) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **increase** coverage by `0.21%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ea484b3 differs from pull request most recent head 2f72380. Consider uploading reports for the commit 2f72380 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
+ Coverage 79.30% 79.52% +0.21%
==========================================
Files 939 939
Lines 47541 47542 +1
Branches 5938 5938
==========================================
+ Hits 37703 37808 +105
+ Misses 9717 9613 -104
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <ø> (+1.82%)` | :arrow_up: |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `95.69% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.85% <0.00%> (-0.43%)` | :arrow_down: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `90.05% <0.00%> (+4.09%)` | :arrow_up: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `86.66% <0.00%> (+6.66%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `82.05% <0.00%> (+7.69%)` | :arrow_up: |
| ... and [10 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...2f72380](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (f78d52e) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
> :exclamation: Current head f78d52e differs from pull request most recent head 8b0faae. Consider uploading reports for the commit 8b0faae to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.01% -0.30%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37563 -140
- Misses 9717 9836 +119
- Partials 121 142 +21
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.28% <ø> (-0.95%)` | :arrow_down: |
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `59.25% <0.00%> (-40.75%)` | :arrow_down: |
| ... and [48 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...8b0faae](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] krsnik93 commented on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
krsnik93 commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817959328
@etr2460
Do you mean updating these two:
https://github.com/apache/superset/blob/master/superset-frontend/images/screenshots/visualizations.png
https://github.com/apache/superset/blob/master/superset-frontend/images/screenshots/visualizations.png
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (a00e48b) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.09% -0.22%
==========================================
Files 939 939
Lines 47541 47542 +1
Branches 5938 5938
==========================================
- Hits 37703 37601 -102
- Misses 9717 9804 +87
- Partials 121 137 +16
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.02% <ø> (-1.22%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| ... and [38 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...a00e48b](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (20d87e5) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `1.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 20d87e5 differs from pull request most recent head 8b0faae. Consider uploading reports for the commit 8b0faae to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 78.30% -1.01%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37227 -476
- Misses 9717 10171 +454
- Partials 121 143 +22
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `46.60% <ø> (-7.64%)` | :arrow_down: |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.49%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [73 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...8b0faae](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-818150124
@junlincc Ephemeral environment spinning up at http://18.236.69.165:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-818060951
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (0e593d9) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 0e593d9 differs from pull request most recent head 740bc0e. Consider uploading reports for the commit 740bc0e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.30% -0.01%
==========================================
Files 939 939
Lines 47541 47542 +1
Branches 5938 5938
==========================================
Hits 37703 37703
- Misses 9717 9718 +1
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...740bc0e](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (3ed79c5) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.23%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 3ed79c5 differs from pull request most recent head f4f7272. Consider uploading reports for the commit f4f7272 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.07% -0.24%
==========================================
Files 939 939
Lines 47541 47542 +1
Branches 5938 5938
==========================================
- Hits 37703 37593 -110
- Misses 9717 9822 +105
- Partials 121 127 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.44% <ø> (-1.80%)` | :arrow_down: |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `47.16% <0.00%> (-33.97%)` | :arrow_down: |
| [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | `57.14% <0.00%> (-11.43%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `56.61% <0.00%> (-10.30%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `58.94% <0.00%> (-9.94%)` | :arrow_down: |
| [.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1VuZG9SZWRvS2V5bGlzdGVuZXJzLmpzeA==) | `57.14% <0.00%> (-9.53%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `72.15% <0.00%> (-8.87%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...f4f7272](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (5281767) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 5281767 differs from pull request most recent head d1cefaf. Consider uploading reports for the commit d1cefaf to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
+ Coverage 79.30% 79.37% +0.06%
==========================================
Files 939 939
Lines 47541 47542 +1
Branches 5938 5938
==========================================
+ Hits 37703 37736 +33
+ Misses 9717 9682 -35
- Partials 121 124 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.74% <ø> (+0.50%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `65.71% <0.00%> (-17.15%)` | :arrow_down: |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `72.41% <0.00%> (-13.80%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreActionButtons.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy50c3g=) | `71.11% <0.00%> (-13.34%)` | :arrow_down: |
| [...rc/explore/components/DisplayQueryButton/index.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24vaW5kZXguanN4) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `71.79% <0.00%> (-7.70%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `63.57% <0.00%> (-5.30%)` | :arrow_down: |
| ... and [25 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...d1cefaf](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (5281767) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 5281767 differs from pull request most recent head a00e48b. Consider uploading reports for the commit a00e48b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
+ Coverage 79.30% 79.37% +0.06%
==========================================
Files 939 939
Lines 47541 47542 +1
Branches 5938 5938
==========================================
+ Hits 37703 37736 +33
+ Misses 9717 9682 -35
- Partials 121 124 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.74% <ø> (+0.50%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `65.71% <0.00%> (-17.15%)` | :arrow_down: |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `72.41% <0.00%> (-13.80%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreActionButtons.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy50c3g=) | `71.11% <0.00%> (-13.34%)` | :arrow_down: |
| [...rc/explore/components/DisplayQueryButton/index.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24vaW5kZXguanN4) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartCard.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRDYXJkLnRzeA==) | `71.79% <0.00%> (-7.70%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `63.57% <0.00%> (-5.30%)` | :arrow_down: |
| ... and [25 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...a00e48b](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (843d920) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 843d920 differs from pull request most recent head d68ce15. Consider uploading reports for the commit d68ce15 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
+ Coverage 79.30% 79.35% +0.04%
==========================================
Files 939 939
Lines 47541 47542 +1
Branches 5938 5938
==========================================
+ Hits 37703 37726 +23
+ Misses 9717 9692 -25
- Partials 121 124 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.80% <ø> (+0.56%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `59.25% <0.00%> (-40.75%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `70.68% <0.00%> (-15.52%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `57.14% <0.00%> (-7.15%)` | :arrow_down: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `33.33% <0.00%> (-2.90%)` | :arrow_down: |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `97.43% <0.00%> (-1.29%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `79.74% <0.00%> (-1.27%)` | :arrow_down: |
| ... and [15 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...d68ce15](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (ea484b3) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **increase** coverage by `0.22%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ea484b3 differs from pull request most recent head 2f72380. Consider uploading reports for the commit 2f72380 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
+ Coverage 79.30% 79.52% +0.22%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
+ Hits 37703 37808 +105
+ Misses 9717 9612 -105
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <ø> (+1.82%)` | :arrow_up: |
| javascript | `69.41% <ø> (ø)` | |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `95.69% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.85% <0.00%> (-0.43%)` | :arrow_down: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `90.05% <0.00%> (+4.09%)` | :arrow_up: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `86.66% <0.00%> (+6.66%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `82.05% <0.00%> (+7.69%)` | :arrow_up: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `90.90% <0.00%> (+8.08%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...2f72380](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-819648641
I'm going to merge this to get the new viz type launched (congrats!) and then we can follow up with further enhancements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (843d920) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **increase** coverage by `0.04%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 843d920 differs from pull request most recent head d68ce15. Consider uploading reports for the commit d68ce15 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
+ Coverage 79.30% 79.35% +0.04%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
+ Hits 37703 37726 +23
+ Misses 9717 9691 -26
- Partials 121 124 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `54.80% <ø> (+0.56%)` | :arrow_up: |
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...trols/DateFilterControl/components/CommonFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NvbW1vbkZyYW1lLnRzeA==) | `41.66% <0.00%> (-41.67%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `59.25% <0.00%> (-40.75%)` | :arrow_down: |
| [...ols/DateFilterControl/components/CalendarFrame.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0NhbGVuZGFyRnJhbWUudHN4) | `46.15% <0.00%> (-38.47%)` | :arrow_down: |
| [...nts/controls/DateFilterControl/DateFilterLabel.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyTGFiZWwudHN4) | `70.68% <0.00%> (-15.52%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/components/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FwcC5qc3g=) | `57.14% <0.00%> (-7.15%)` | :arrow_down: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `33.33% <0.00%> (-2.90%)` | :arrow_down: |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `97.43% <0.00%> (-1.29%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `79.74% <0.00%> (-1.27%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `83.72% <0.00%> (-0.78%)` | :arrow_down: |
| ... and [14 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...d68ce15](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-818920134
A couple of cosmetic/overlapping issues in Customize tab. Not blocker, @krsnik93 can we open a follow up PR to address those after this PR is merged? Many thanks 🙏 @EBoisseauSierra @krsnik93
1.
<img width="983" alt="Screen Shot 2021-04-13 at 9 51 00 AM" src="https://user-images.githubusercontent.com/67837651/114596116-104b1f80-9c44-11eb-949b-0bfca6e2f1ad.png">
2.
<img width="1514" alt="Screen Shot 2021-04-13 at 9 52 18 AM" src="https://user-images.githubusercontent.com/67837651/114596180-26f17680-9c44-11eb-99d8-419967b2401a.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (20d87e5) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 20d87e5 differs from pull request most recent head 8b0faae. Consider uploading reports for the commit 8b0faae to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.28% -0.03%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37691 -12
- Misses 9717 9724 +7
- Partials 121 126 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.95% <ø> (-0.29%)` | :arrow_down: |
| javascript | `69.41% <ø> (ø)` | |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `58.49% <0.00%> (-15.10%)` | :arrow_down: |
| [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | `54.28% <0.00%> (-14.29%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `58.08% <0.00%> (-8.83%)` | :arrow_down: |
| [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | `92.30% <0.00%> (-7.70%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `73.17% <0.00%> (-7.32%)` | :arrow_down: |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `78.57% <0.00%> (-7.15%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...8b0faae](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (3ed79c5) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **increase** coverage by `0.21%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 3ed79c5 differs from pull request most recent head f4f7272. Consider uploading reports for the commit f4f7272 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
+ Coverage 79.30% 79.52% +0.21%
==========================================
Files 939 939
Lines 47541 47542 +1
Branches 5938 5938
==========================================
+ Hits 37703 37807 +104
+ Misses 9717 9614 -103
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (+1.81%)` | :arrow_up: |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `95.69% <0.00%> (-1.08%)` | :arrow_down: |
| [...dashboard/components/SliceHeaderControls/index.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMvaW5kZXguanN4) | `77.89% <0.00%> (-1.06%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.85% <0.00%> (-0.43%)` | :arrow_down: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `90.05% <0.00%> (+4.09%)` | :arrow_up: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `86.66% <0.00%> (+6.66%)` | :arrow_up: |
| ... and [11 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...f4f7272](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] krsnik93 commented on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
krsnik93 commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-819298103
@junlincc Thanks for reporting this.
I can add more space between the axis and the label but then it won't look great for numbers with just a few digits. If you look closely at the second image, numbers like 0, 10, 20 etc look properly distanced from the axis. The issue is that Echarts seems to take the starting position and then render inwards, so if the number has a lot of digits, it ends up going over the axis. There is a single setting for label distance (We cannot set different values depending on the number of digits/chars etc.). I think the combination of tuning the split number (so that the values don't overlap between themselves) and the adaptive formatting (so that there are no values with a lot of digits) should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] krsnik93 edited a comment on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
krsnik93 edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817959328
@etr2460
Do you mean updating these two:
https://github.com/apache/superset/blob/master/superset-frontend/images/screenshots/visualizations.png
https://github.com/apache/superset/blob/master/superset-frontend/images/screenshots/visualizations.png
EDIT: maybe adding a thumbnail into https://github.com/apache/superset/tree/master/superset-frontend/images/viz_thumbnails as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on a change in pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #14072:
URL: https://github.com/apache/superset/pull/14072#discussion_r611776576
##########
File path: superset-frontend/src/visualizations/presets/MainPreset.js
##########
@@ -91,6 +92,7 @@ export default class MainPreset extends Preset {
new EventFlowChartPlugin().configure({ key: 'event_flow' }),
new FilterBoxChartPlugin().configure({ key: 'filter_box' }),
new EchartsGraphChartPlugin().configure({ key: 'graph_chart' }),
+ new EchartsGaugeChartPlugin().configure({ key: 'gauge_chart' }),
Review comment:
looks like we're trying to keep this in abc order, so let's put this before the `graph_chart`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (91c0c43) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `1.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 91c0c43 differs from pull request most recent head 740bc0e. Consider uploading reports for the commit 740bc0e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 78.27% -1.03%
==========================================
Files 939 939
Lines 47541 47540 -1
Branches 5938 5938
==========================================
- Hits 37703 37214 -489
- Misses 9717 10178 +461
- Partials 121 148 +27
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `46.64% <ø> (-7.60%)` | :arrow_down: |
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-84.62%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.49%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-77.78%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `35.00% <0.00%> (-65.00%)` | :arrow_down: |
| ... and [66 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...740bc0e](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (20d87e5) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 20d87e5 differs from pull request most recent head 7844784. Consider uploading reports for the commit 7844784 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.28% -0.03%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37691 -12
- Misses 9717 9724 +7
- Partials 121 126 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.95% <ø> (-0.29%)` | :arrow_down: |
| javascript | `69.41% <ø> (ø)` | |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...nd/src/dashboard/util/getFilterValuesByFilterId.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclZhbHVlc0J5RmlsdGVySWQuanM=) | `25.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...rontend/src/visualizations/FilterBox/FilterBox.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9GaWx0ZXJCb3guanN4) | `58.49% <0.00%> (-15.10%)` | :arrow_down: |
| [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | `54.28% <0.00%> (-14.29%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `58.08% <0.00%> (-8.83%)` | :arrow_down: |
| [...nd/src/dashboard/containers/DashboardComponent.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZENvbXBvbmVudC5qc3g=) | `92.30% <0.00%> (-7.70%)` | :arrow_down: |
| [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `73.17% <0.00%> (-7.32%)` | :arrow_down: |
| [...-frontend/src/dashboard/reducers/dashboardState.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRTdGF0ZS5qcw==) | `78.57% <0.00%> (-7.15%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...7844784](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34d2d27) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4fd6b8) will **decrease** coverage by `0.03%`.
> The diff coverage is `67.27%`.
> :exclamation: Current head 34d2d27 differs from pull request most recent head ab4391b. Consider uploading reports for the commit ab4391b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.26% -0.04%
==========================================
Files 939 939
Lines 47541 47576 +35
Branches 5938 5949 +11
==========================================
+ Hits 37703 37712 +9
- Misses 9717 9742 +25
- Partials 121 122 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <60.60%> (+1.79%)` | :arrow_up: |
| hive | `?` | |
| presto | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nd/src/dashboard/util/activeAllDashboardFilters.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2FjdGl2ZUFsbERhc2hib2FyZEZpbHRlcnMudHM=) | `100.00% <ø> (ø)` | |
| [...tend/src/filters/components/Select/controlPanel.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvY29udHJvbFBhbmVsLnRz) | `18.18% <0.00%> (-1.82%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `66.66% <ø> (-33.34%)` | :arrow_down: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `65.21% <10.00%> (-3.66%)` | :arrow_down: |
| [superset/reports/notifications/slack.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL3NsYWNrLnB5) | `86.36% <50.00%> (ø)` | |
| [superset/views/base.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `76.47% <50.00%> (-0.40%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `76.92% <77.27%> (-3.57%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `100.00% <100.00%> (ø)` | |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `81.81% <100.00%> (ø)` | |
| ... and [31 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a4fd6b8...ab4391b](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (ea484b3) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **increase** coverage by `0.22%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ea484b3 differs from pull request most recent head f4f7272. Consider uploading reports for the commit f4f7272 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
+ Coverage 79.30% 79.52% +0.22%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
+ Hits 37703 37808 +105
+ Misses 9717 9612 -105
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <ø> (+1.82%)` | :arrow_up: |
| javascript | `69.41% <ø> (ø)` | |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `95.69% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.85% <0.00%> (-0.43%)` | :arrow_down: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `90.05% <0.00%> (+4.09%)` | :arrow_up: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `86.66% <0.00%> (+6.66%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `82.05% <0.00%> (+7.69%)` | :arrow_up: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `90.90% <0.00%> (+8.08%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...f4f7272](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (91c0c43) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `1.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 91c0c43 differs from pull request most recent head d68ce15. Consider uploading reports for the commit d68ce15 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 78.27% -1.03%
==========================================
Files 939 939
Lines 47541 47540 -1
Branches 5938 5938
==========================================
- Hits 37703 37214 -489
- Misses 9717 10178 +461
- Partials 121 148 +27
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `46.64% <ø> (-7.60%)` | :arrow_down: |
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-84.62%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.49%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-77.78%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `35.00% <0.00%> (-65.00%)` | :arrow_down: |
| ... and [66 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...d68ce15](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] krsnik93 commented on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
krsnik93 commented on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-819300704
It seems like the overlap happens for all non-int labels so I will increase the label distance a bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (7844784) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.16%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 7844784 differs from pull request most recent head 92fb380. Consider uploading reports for the commit 92fb380 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.14% -0.17%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37625 -78
- Misses 9717 9792 +75
- Partials 121 124 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.52% <ø> (-1.72%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...hboard/components/filterscope/FilterScopeModal.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwudHN4) | `31.25% <0.00%> (-43.75%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `59.25% <0.00%> (-40.75%)` | :arrow_down: |
| [...et-frontend/src/dashboard/components/SaveModal.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC50c3g=) | `47.16% <0.00%> (-33.97%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `47.79% <0.00%> (-19.12%)` | :arrow_down: |
| [...nd/src/explore/components/ExploreActionButtons.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQWN0aW9uQnV0dG9ucy50c3g=) | `71.11% <0.00%> (-13.34%)` | :arrow_down: |
| [...t-frontend/src/dashboard/actions/dashboardState.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZFN0YXRlLmpz) | `56.29% <0.00%> (-12.59%)` | :arrow_down: |
| [...rc/explore/components/DisplayQueryButton/index.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EaXNwbGF5UXVlcnlCdXR0b24vaW5kZXguanN4) | `87.50% <0.00%> (-12.50%)` | :arrow_down: |
| [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | `57.14% <0.00%> (-11.43%)` | :arrow_down: |
| ... and [24 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...92fb380](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (ea484b3) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **increase** coverage by `0.22%`.
> The diff coverage is `n/a`.
> :exclamation: Current head ea484b3 differs from pull request most recent head e5a1a28. Consider uploading reports for the commit e5a1a28 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
+ Coverage 79.30% 79.52% +0.22%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
+ Hits 37703 37808 +105
+ Misses 9717 9612 -105
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.06% <ø> (+1.82%)` | :arrow_up: |
| javascript | `69.41% <ø> (ø)` | |
| postgres | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [superset/sql\_validators/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3ZhbGlkYXRvcnMvcG9zdGdyZXMucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `95.69% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | `97.85% <0.00%> (-0.43%)` | :arrow_down: |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `90.05% <0.00%> (+4.09%)` | :arrow_up: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `86.66% <0.00%> (+6.66%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `82.05% <0.00%> (+7.69%)` | :arrow_up: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `90.90% <0.00%> (+8.08%)` | :arrow_up: |
| ... and [9 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...e5a1a28](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: [WIP] add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc) (f78d52e) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc) (a4fd6b8) will **decrease** coverage by `0.29%`.
> The diff coverage is `n/a`.
> :exclamation: Current head f78d52e differs from pull request most recent head a00e48b. Consider uploading reports for the commit a00e48b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
- Coverage 79.30% 79.01% -0.30%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
- Hits 37703 37563 -140
- Misses 9717 9836 +119
- Partials 121 142 +21
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `53.28% <ø> (-0.95%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tend/src/visualizations/FilterBox/controlPanel.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL0ZpbHRlckJveC9jb250cm9sUGFuZWwuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| [...ontend/src/dashboard/util/serializeFilterScopes.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3NlcmlhbGl6ZUZpbHRlclNjb3Blcy5qcw==) | `40.00% <0.00%> (-60.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/sliceEntities.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL3NsaWNlRW50aXRpZXMuanM=) | `12.90% <0.00%> (-58.07%)` | :arrow_down: |
| [...frontend/src/dashboard/components/AddSliceCard.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC5qc3g=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...set-frontend/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXRhc291cmNlcy5qcw==) | `57.14% <0.00%> (-42.86%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/actions/datasources.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2RhdGFzb3VyY2VzLmpz) | `15.78% <0.00%> (-42.11%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `59.25% <0.00%> (-40.75%)` | :arrow_down: |
| ... and [48 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer). Last update [a4fd6b8...a00e48b](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #14072: feat: add Echarts gauge chart
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14072:
URL: https://github.com/apache/superset/pull/14072#issuecomment-817189740
# [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#14072](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f4f7272) into [master](https://codecov.io/gh/apache/superset/commit/a4fd6b8f33e9e780084a71f3e5b579468cdd635b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4fd6b8) will **increase** coverage by `0.24%`.
> The diff coverage is `n/a`.
> :exclamation: Current head f4f7272 differs from pull request most recent head ab4391b. Consider uploading reports for the commit ab4391b to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #14072 +/- ##
==========================================
+ Coverage 79.30% 79.55% +0.24%
==========================================
Files 939 939
Lines 47541 47541
Branches 5938 5938
==========================================
+ Hits 37703 37819 +116
+ Misses 9717 9601 -116
Partials 121 121
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.05% <ø> (+1.82%)` | :arrow_up: |
| javascript | `69.41% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/EditableTitle/index.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS9pbmRleC50c3g=) | `75.30% <0.00%> (+1.23%)` | :arrow_up: |
| [superset-frontend/src/views/routes.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL3JvdXRlcy50c3g=) | `56.81% <0.00%> (+2.27%)` | :arrow_up: |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `90.05% <0.00%> (+4.09%)` | :arrow_up: |
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `86.66% <0.00%> (+6.66%)` | :arrow_up: |
| [...rontend/src/views/CRUD/dashboard/DashboardCard.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGFzaGJvYXJkL0Rhc2hib2FyZENhcmQudHN4) | `82.05% <0.00%> (+7.69%)` | :arrow_up: |
| [...c/dashboard/components/gridComponents/Markdown.jsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL01hcmtkb3duLmpzeA==) | `90.90% <0.00%> (+8.08%)` | :arrow_up: |
| [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=) | `58.93% <0.00%> (+9.66%)` | :arrow_up: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `100.00% <0.00%> (+11.11%)` | :arrow_up: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `78.94% <0.00%> (+11.11%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/superset/pull/14072/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a4fd6b8...ab4391b](https://codecov.io/gh/apache/superset/pull/14072?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org