You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/02/17 10:31:59 UTC

[GitHub] [superset] zhaoyongjie edited a comment on pull request #18779: refactor: move post_processing to unittest

zhaoyongjie edited a comment on pull request #18779:
URL: https://github.com/apache/superset/pull/18779#issuecomment-1042771967


   > Love the change to proper unit tests! One question about the change in the contribution operator - should we potentially split this PR in two - the first for the refactor, and the second for the functional change once the refactor has been merged?
   
   it's my bad. I'm gonna split it to 2 PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org