You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/12 21:34:21 UTC
[GitHub] [pulsar] nlu90 opened a new pull request #13727: fix checkstyle for TableViewBuilder
nlu90 opened a new pull request #13727:
URL: https://github.com/apache/pulsar/pull/13727
### Motivation
The TableView PR https://github.com/apache/pulsar/pull/12838 was developed before the checkstyle was enabled. So now it's failing the CI check after it's merged.
```
Error: src/main/java/org/apache/pulsar/client/api/TableViewBuilder.java:[25,1] (imports) ImportOrder: Extra separation in import group before 'java.util.Map'
Error: src/main/java/org/apache/pulsar/client/api/TableViewBuilder.java:[25,1] (imports) ImportOrder: Import java.util.Map appears after other imports that it should precede
Error: src/main/java/org/apache/pulsar/client/api/TableViewBuilder.java:[81] (javadoc) JavadocStyle: First sentence should end with a period.
Error: src/main/java/org/apache/pulsar/client/api/TableViewBuilder.java:[89] (javadoc) JavadocStyle: First sentence should end with a period.
Error: Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.2:check (checkstyle) on project pulsar-client-api: You have 4 Checkstyle violations. -> [Help 1]
```
### Modifications
Fix the mentioned checkstyle errors
### Verifying this change
```
➜ sn-pulsar git:(neng/tableview-checkstyle) ✗ mvn checkstyle:check -Dpulsar.basedir=. -pl pulsar-client-api
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Detecting the operating system and CPU architecture
[INFO] ------------------------------------------------------------------------
[INFO] os.detected.name: osx
[INFO] os.detected.arch: x86_64
[INFO] os.detected.classifier: osx-x86_64
[INFO]
[INFO] ----------------< org.apache.pulsar:pulsar-client-api >-----------------
[INFO] Building Pulsar Client :: API 2.10.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ pulsar-client-api ---
[INFO] You have 0 Checkstyle violations.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2.272 s
[INFO] Finished at: 2022-01-12T13:33:23-08:00
[INFO] ------------------------------------------------------------------------
```
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [X] `no-need-doc`
Simple checkstyle fix
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #13727: fix checkstyle for TableViewBuilder
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #13727:
URL: https://github.com/apache/pulsar/pull/13727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org