You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/05/06 22:12:08 UTC
[GitHub] [geode] smgoller opened a new pull request #5066: [GEODE-8083] Add API Checking to Geode.
smgoller opened a new pull request #5066:
URL: https://github.com/apache/geode/pull/5066
* Add API check gradle task.
* Add CI job that calls API check gradle task.
* Fix spotless rules so it doesn't mistakenly mess up our gradle.
Co-authored-by: Sean Goller <sg...@pivotal.io>
Co-authored-by: Robert Houghton <rh...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #5066: [GEODE-8083] Add API Checking to Geode.
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #5066:
URL: https://github.com/apache/geode/pull/5066#issuecomment-624959652
Is this job likely to be red or green initially? Since our last release version is 1.12.0, if there have been any inadvertent breaking API changes since then, do they need to be addressed first?
Is there any mechanism to add an exclude/override if this tool flags something that we decide we are ok with?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on a change in pull request #5066: [GEODE-8083] Add API Checking to Geode.
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on a change in pull request #5066:
URL: https://github.com/apache/geode/pull/5066#discussion_r421165685
##########
File path: ci/pipelines/shared/jinja.variables.yml
##########
@@ -202,3 +202,15 @@ tests:
PLATFORM: windows
RAM: '64'
name: WindowsUnit
+- ARTIFACT_SLUG: apicheck
+ CALL_STACK_TIMEOUT: '20700'
Review comment:
maybe not applicable to this job? But in general CALL_STACK_TIMEOUT should be 10-15 minutes less than EXECUTE_TEST_TIMEOUT, which you've set to 1h. So `2700` might be a better choice.
##########
File path: ci/pipelines/shared/jinja.variables.yml
##########
@@ -202,3 +202,15 @@ tests:
PLATFORM: windows
RAM: '64'
name: WindowsUnit
+- ARTIFACT_SLUG: apicheck
+ CALL_STACK_TIMEOUT: '20700'
+ CPUS: '4'
+ DUNIT_PARALLEL_FORKS: '0'
+ EXECUTE_TEST_TIMEOUT: 1h
+ GRADLE_TASK: geode-assembly:japicmp
+ MAX_IN_FLIGHT: 1
+ PARALLEL_DUNIT: 'false'
+ PARALLEL_GRADLE: 'false'
+ PLATFORM: linux
+ RAM: '16'
+ name: ApiCheck
Review comment:
will this result in both ApiCheckOpenJdk8 and ApiCheckOpenJdk11 jobs? Is there any value to having both? Ideally we would add a new flag in jinja.variables to allow each job to specify JDK version(s) desired per job. But that can be a future enhancement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org