You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/02 10:20:01 UTC
[GitHub] [airflow] potiuk opened a new pull request #15157: Increase timeout for building the docs
potiuk opened a new pull request #15157:
URL: https://github.com/apache/airflow/pull/15157
Sometimes when docs are building in parallel, it takes longer
than 4 minutes to build a big package and the job fails with
timeout.
This change increases the individual package build timeout to
be longer (8 minutes instead of 4)
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek merged pull request #15157: Increase timeout for building the docs
Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #15157:
URL: https://github.com/apache/airflow/pull/15157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] feluelle commented on a change in pull request #15157: Increase timeout for building the docs
Posted by GitBox <gi...@apache.org>.
feluelle commented on a change in pull request #15157:
URL: https://github.com/apache/airflow/pull/15157#discussion_r606185545
##########
File path: docs/exts/docs_build/code_utils.py
##########
@@ -30,7 +30,7 @@
DOCKER_AIRFLOW_DIR = os.path.join(DOCKER_PROJECT_DIR, "/airflow")
ALL_PROVIDER_YAMLS = load_package_data()
AIRFLOW_SITE_DIR = os.environ.get('AIRFLOW_SITE_DIRECTORY')
-PROCESS_TIMEOUT = 4 * 60
+PROCESS_TIMEOUT = 8 * 60 # 400 seconds
Review comment:
8*60 = 400? Isn't it just 8 mins?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #15157: Increase timeout for building the docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #15157:
URL: https://github.com/apache/airflow/pull/15157#issuecomment-812649784
Anyone else? Really small but improves stability of the build (I've seen the timeouts occuring several times already).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #15157: Increase timeout for building the docs
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #15157:
URL: https://github.com/apache/airflow/pull/15157#issuecomment-812649784
Anyone else? Really small but improves stability of the build (I've seen the timeouts occurring several times already).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #15157: Increase timeout for building the docs
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #15157:
URL: https://github.com/apache/airflow/pull/15157#discussion_r606650349
##########
File path: docs/exts/docs_build/code_utils.py
##########
@@ -30,7 +30,7 @@
DOCKER_AIRFLOW_DIR = os.path.join(DOCKER_PROJECT_DIR, "/airflow")
ALL_PROVIDER_YAMLS = load_package_data()
AIRFLOW_SITE_DIR = os.environ.get('AIRFLOW_SITE_DIRECTORY')
-PROCESS_TIMEOUT = 4 * 60
+PROCESS_TIMEOUT = 8 * 60 # 400 seconds
Review comment:
8*60 = 480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15157: Increase timeout for building the docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15157:
URL: https://github.com/apache/airflow/pull/15157#discussion_r606204773
##########
File path: docs/exts/docs_build/code_utils.py
##########
@@ -30,7 +30,7 @@
DOCKER_AIRFLOW_DIR = os.path.join(DOCKER_PROJECT_DIR, "/airflow")
ALL_PROVIDER_YAMLS = load_package_data()
AIRFLOW_SITE_DIR = os.environ.get('AIRFLOW_SITE_DIRECTORY')
-PROCESS_TIMEOUT = 4 * 60
+PROCESS_TIMEOUT = 8 * 60 # 400 seconds
Review comment:
```suggestion
PROCESS_TIMEOUT = 8 * 60
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a change in pull request #15157: Increase timeout for building the docs
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #15157:
URL: https://github.com/apache/airflow/pull/15157#discussion_r606650349
##########
File path: docs/exts/docs_build/code_utils.py
##########
@@ -30,7 +30,7 @@
DOCKER_AIRFLOW_DIR = os.path.join(DOCKER_PROJECT_DIR, "/airflow")
ALL_PROVIDER_YAMLS = load_package_data()
AIRFLOW_SITE_DIR = os.environ.get('AIRFLOW_SITE_DIRECTORY')
-PROCESS_TIMEOUT = 4 * 60
+PROCESS_TIMEOUT = 8 * 60 # 400 seconds
Review comment:
8*80 = 480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15157: Increase timeout for building the docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15157:
URL: https://github.com/apache/airflow/pull/15157#discussion_r606652423
##########
File path: docs/exts/docs_build/code_utils.py
##########
@@ -30,7 +30,7 @@
DOCKER_AIRFLOW_DIR = os.path.join(DOCKER_PROJECT_DIR, "/airflow")
ALL_PROVIDER_YAMLS = load_package_data()
AIRFLOW_SITE_DIR = os.environ.get('AIRFLOW_SITE_DIRECTORY')
-PROCESS_TIMEOUT = 4 * 60
+PROCESS_TIMEOUT = 8 * 60 # 400 seconds
Review comment:
8*80 = 640 ;) . Yeah. I removed the comment as it would be all to easy to get it out of sync as it was there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #15157: Increase timeout for building the docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #15157:
URL: https://github.com/apache/airflow/pull/15157#discussion_r606205097
##########
File path: docs/exts/docs_build/code_utils.py
##########
@@ -30,7 +30,7 @@
DOCKER_AIRFLOW_DIR = os.path.join(DOCKER_PROJECT_DIR, "/airflow")
ALL_PROVIDER_YAMLS = load_package_data()
AIRFLOW_SITE_DIR = os.environ.get('AIRFLOW_SITE_DIRECTORY')
-PROCESS_TIMEOUT = 4 * 60
+PROCESS_TIMEOUT = 8 * 60 # 400 seconds
Review comment:
yeah.. I changed/commented out and did not remove it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org