[jira] [Commented] (SENTRY-2085) Sentry error handling exposes SentryGroupNotFoundException externally

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SENTRY-2085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310231#comment-16310231 ] 

Hadoop QA commented on SENTRY-2085:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12904440/SENTRY-2085.006.patch against master.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} all tests passed

Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/3598/console

This message is automatically generated.

> Sentry error handling exposes SentryGroupNotFoundException externally
> ---------------------------------------------------------------------
>
>                 Key: SENTRY-2085
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2085
>             Project: Sentry
>          Issue Type: Bug
>    Affects Versions: 2.1.0
>            Reporter: Zach Amsden
>            Assignee: Zach Amsden
>         Attachments: SENTRY-2085.001.patch, SENTRY-2085.002.patch, SENTRY-2085.003.patch, SENTRY-2085.004.patch, SENTRY-2085.006.patch
>
>
> The fix for SENTRY-769 allowed better differentiation of Sentry errors but also unnecessarily leaked exceptions outside of well defined API components.  This happens because the exception chosen, SentryGroupNotFoundException was created of a subclass of RuntimeError, allowing it to propagate past API boundaries without 'throws' or 'catch' clauses.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)