You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Jeanne Waldman (JIRA)" <ad...@incubator.apache.org> on 2006/07/11 17:38:29 UTC
[jira] Created: (ADFFACES-55) inhibit skinning css properties
inhibit skinning css properties
-------------------------------
Key: ADFFACES-55
URL: http://issues.apache.org/jira/browse/ADFFACES-55
Project: MyFaces ADF-Faces
Type: New Feature
Reporter: Jeanne Waldman
Add a skinning css custom property to all a selector to inhibit all properties it would normally inherit, or to inhibit specific properties. For example:
.foo {-oam-inhibit: all}
.bar {-oam-inhibit: text-align font-size color}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-55) inhibit skinning css properties
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-55?page=comments#action_12420393 ]
Simon Lessard commented on ADFFACES-55:
---------------------------------------
Removed my entry about this issue since Jeanne was the first to bring it up on the dev list, so it's fair that she get the entry here as well.
> inhibit skinning css properties
> -------------------------------
>
> Key: ADFFACES-55
> URL: http://issues.apache.org/jira/browse/ADFFACES-55
> Project: MyFaces ADF-Faces
> Type: New Feature
> Reporter: Jeanne Waldman
>
> Add a skinning css custom property to all a selector to inhibit all properties it would normally inherit, or to inhibit specific properties. For example:
> .foo {-oam-inhibit: all}
> .bar {-oam-inhibit: text-align font-size color}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-55) inhibit skinning css properties
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-55?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-55:
---------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> inhibit skinning css properties
> -------------------------------
>
> Key: ADFFACES-55
> URL: https://issues.apache.org/jira/browse/ADFFACES-55
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Affects Versions: 1.0.0-incubating-core
> Reporter: Jeanne Waldman
> Fix For: 1.0.0-incubating-core
>
> Attachments: Inhibit.patch, Inhibit_v2.patch
>
>
> Add a skinning css custom property to all a selector to inhibit all properties it would normally inherit, or to inhibit specific properties. For example:
> .foo {-oam-inhibit: all}
> .bar {-oam-inhibit: text-align font-size color}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-55) inhibit skinning css properties
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-55?page=all ]
Simon Lessard updated ADFFACES-55:
----------------------------------
Attachment: Inhibit_v2.patch
Applies Adam suggestion. Also fix some coding convention I was not following (had a private member not using underscore prefix).
> inhibit skinning css properties
> -------------------------------
>
> Key: ADFFACES-55
> URL: http://issues.apache.org/jira/browse/ADFFACES-55
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Jeanne Waldman
> Attachments: Inhibit.patch, Inhibit_v2.patch
>
>
> Add a skinning css custom property to all a selector to inhibit all properties it would normally inherit, or to inhibit specific properties. For example:
> .foo {-oam-inhibit: all}
> .bar {-oam-inhibit: text-align font-size color}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-55) inhibit skinning css properties
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-55?page=all ]
Simon Lessard updated ADFFACES-55:
----------------------------------
Attachment: Inhibit.patch
Enable -ora-inhibit inside CSS skins. the synthax is:
-ora-inhibit: all;
or
-ora-inhibit: <propertyName1> <propertyName2> <propertyName3> ...;
> inhibit skinning css properties
> -------------------------------
>
> Key: ADFFACES-55
> URL: http://issues.apache.org/jira/browse/ADFFACES-55
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Jeanne Waldman
> Attachments: Inhibit.patch
>
>
> Add a skinning css custom property to all a selector to inhibit all properties it would normally inherit, or to inhibit specific properties. For example:
> .foo {-oam-inhibit: all}
> .bar {-oam-inhibit: text-align font-size color}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-55) inhibit skinning css properties
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-55?page=all ]
Adam Winer updated ADFFACES-55:
-------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
> inhibit skinning css properties
> -------------------------------
>
> Key: ADFFACES-55
> URL: http://issues.apache.org/jira/browse/ADFFACES-55
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Jeanne Waldman
> Attachments: Inhibit.patch, Inhibit_v2.patch
>
>
> Add a skinning css custom property to all a selector to inhibit all properties it would normally inherit, or to inhibit specific properties. For example:
> .foo {-oam-inhibit: all}
> .bar {-oam-inhibit: text-align font-size color}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-55) inhibit skinning css properties
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-55?page=comments#action_12428315 ]
Adam Winer commented on ADFFACES-55:
------------------------------------
Simon: one thing in the patch I don't get:
+ if(inhibitedProperties.contains(INHIBIT_ALL_VALUE))
+ {
+ _inhibitAll = true;
+ _inhibitedProperties = new ArrayList<String>(inhibitedProperties.size()-1);
+ for(String property : inhibitedProperties)
+ {
+ _inhibitedProperties.add(property);
+ }
+ }
+ else
+ {
+ _inhibitedProperties = new ArrayList<String>(inhibitedProperties);
+ }
Shouldn't _inhibitedProperties be empty if "all" is present, since _inhibitAll
is sufficent? Or, at least, is the intent here something more like:
+ for(String property : inhibitedProperties)
+ {
+ if (!property.equals(INHIBIT_ALL_VALUE)
+ _inhibitedProperties.add(property);
+ }
> inhibit skinning css properties
> -------------------------------
>
> Key: ADFFACES-55
> URL: http://issues.apache.org/jira/browse/ADFFACES-55
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Jeanne Waldman
> Attachments: Inhibit.patch
>
>
> Add a skinning css custom property to all a selector to inhibit all properties it would normally inherit, or to inhibit specific properties. For example:
> .foo {-oam-inhibit: all}
> .bar {-oam-inhibit: text-align font-size color}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-55) inhibit skinning css properties
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-55?page=comments#action_12428389 ]
Simon Lessard commented on ADFFACES-55:
---------------------------------------
You're perfectly right, the second option would have been more efficient and easier to read. I could also make _inhibitedProperties empty since getInhibitedProperties() is not called when all is present. I'll make a patch using the latter option I think and just document it so that users know that calling getInhibitedProperties always return an empty list if isInhibitingAll returns true.
> inhibit skinning css properties
> -------------------------------
>
> Key: ADFFACES-55
> URL: http://issues.apache.org/jira/browse/ADFFACES-55
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Jeanne Waldman
> Attachments: Inhibit.patch
>
>
> Add a skinning css custom property to all a selector to inhibit all properties it would normally inherit, or to inhibit specific properties. For example:
> .foo {-oam-inhibit: all}
> .bar {-oam-inhibit: text-align font-size color}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-55) inhibit skinning css properties
Posted by "Simon Lessard (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-55?page=all ]
Simon Lessard updated ADFFACES-55:
----------------------------------
Status: Patch Available (was: Open)
> inhibit skinning css properties
> -------------------------------
>
> Key: ADFFACES-55
> URL: http://issues.apache.org/jira/browse/ADFFACES-55
> Project: MyFaces ADF-Faces
> Issue Type: New Feature
> Reporter: Jeanne Waldman
>
> Add a skinning css custom property to all a selector to inhibit all properties it would normally inherit, or to inhibit specific properties. For example:
> .foo {-oam-inhibit: all}
> .bar {-oam-inhibit: text-align font-size color}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira