You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/08/19 06:40:23 UTC
[GitHub] [apisix-dashboard] ljzsmllx opened a new pull request, #2597: OpenID-Connect
ljzsmllx opened a new pull request, #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Please update this section with detailed description.
The series PR will add a new feature to the Dashboard to make it support login through OpenID-Connect.
This PR only adds some new config information to the config file.
**Related issues**
**Checklist:**
- [ ] Did you explain what problem does this PR solve? Or what new features have been added?
- [ ] Have you added corresponding test cases?
- [ ] Have you modified the corresponding document?
- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ljzsmllx commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
ljzsmllx commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r955609021
##########
api/internal/conf/conf.go:
##########
@@ -283,6 +298,14 @@ func initAuthentication(conf Authentication) {
}
}
+func initOidc(conf Oidc) {
+ OidcConf = conf
+
+ if OidcConf.Secret == "secret" {
+ OidcConf.Secret = utils.GetFlakeUidStr()
Review Comment:
After thinking twice, I think the `secret` is not necessary, I will delete it in the next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
nic-chen commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r955540148
##########
api/internal/handler/data_loader/route_import.go:
##########
@@ -113,7 +113,6 @@ func (h *ImportHandler) Import(c droplet.Context) (interface{}, error) {
MergeMethod: input.MergeMethod == "true",
TaskName: input.TaskName,
}
- break
Review Comment:
why change this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ljzsmllx commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
ljzsmllx commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r950866706
##########
api/conf/conf.yaml:
##########
@@ -19,26 +19,26 @@
conf:
listen:
# host: 127.0.0.1 # the address on which the `Manager API` should listen.
- # The default value is 0.0.0.0, if want to specify, please enable it.
- # This value accepts IPv4, IPv6, and hostname.
+ # The default value is 0.0.0.0, if want to specify, please enable it.
+ # This value accepts IPv4, IPv6, and hostname.
port: 9000 # The port on which the `Manager API` should listen.
- # ssl:
- # host: 127.0.0.1 # the address on which the `Manager API` should listen for HTTPS.
- # The default value is 0.0.0.0, if want to specify, please enable it.
+ # ssl:
+ # host: 127.0.0.1 # the address on which the `Manager API` should listen for HTTPS.
Review Comment:
Sorry, hand shaking...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
starsz commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r953504431
##########
api/conf/conf.yaml:
##########
@@ -80,6 +80,17 @@ authentication:
- username: user
password: user
+oidc:
+ secret:
+ secret
+ expire_time: 3600
+ apps:
+ - app_name: authing
+ client_id:
+ client_secret:
+ scope: oidc
+ redirect_uri: /authing/callback
Review Comment:
`redirect_uri` shouldn't contain the `authing` config.
Maybe `oidc/callback`.
##########
api/conf/conf.yaml:
##########
@@ -80,6 +80,17 @@ authentication:
- username: user
password: user
+oidc:
+ secret:
+ secret
+ expire_time: 3600
+ apps:
+ - app_name: authing
Review Comment:
I think we can support one app first.
So just remove apps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ljzsmllx commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
ljzsmllx commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r955605304
##########
api/internal/handler/data_loader/route_import.go:
##########
@@ -113,7 +113,6 @@ func (h *ImportHandler) Import(c droplet.Context) (interface{}, error) {
MergeMethod: input.MergeMethod == "true",
TaskName: input.TaskName,
}
- break
Review Comment:
The go-lint advised me to change this. I just followed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ljzsmllx commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
ljzsmllx commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r953531629
##########
api/conf/conf.yaml:
##########
@@ -80,6 +80,17 @@ authentication:
- username: user
password: user
+oidc:
+ secret:
+ secret
+ expire_time: 3600
+ apps:
+ - app_name: authing
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ljzsmllx commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
ljzsmllx commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r953531872
##########
api/conf/conf.yaml:
##########
@@ -80,6 +80,17 @@ authentication:
- username: user
password: user
+oidc:
+ secret:
+ secret
+ expire_time: 3600
+ apps:
+ - app_name: authing
+ client_id:
+ client_secret:
+ scope: oidc
+ redirect_uri: /authing/callback
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz merged pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
starsz merged PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ljzsmllx commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
ljzsmllx commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r955607086
##########
api/internal/handler/data_loader/route_import.go:
##########
@@ -113,7 +113,6 @@ func (h *ImportHandler) Import(c droplet.Context) (interface{}, error) {
MergeMethod: input.MergeMethod == "true",
TaskName: input.TaskName,
}
- break
Review Comment:
I will change it back in next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ljzsmllx commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
ljzsmllx commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r955605304
##########
api/internal/handler/data_loader/route_import.go:
##########
@@ -113,7 +113,6 @@ func (h *ImportHandler) Import(c droplet.Context) (interface{}, error) {
MergeMethod: input.MergeMethod == "true",
TaskName: input.TaskName,
}
- break
Review Comment:
The go-lint advised me to change this. I just followed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
nic-chen commented on PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#issuecomment-1229115448
Maybe we should merge to the `next` branch now?
Looks like in later versions we will use `next` branch instead of `master`?
@bzp2010 @starsz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] ljzsmllx commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
ljzsmllx commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r950866738
##########
api/conf/conf.yaml:
##########
@@ -71,15 +71,27 @@ conf:
authentication:
secret:
secret # secret for jwt token generation.
- # NOTE: Highly recommended to modify this value to protect `manager api`.
- # if it's default value, when `manager api` start, it will generate a random string to replace it.
+ # NOTE: Highly recommended to modify this value to protect `manager api`.
+ # if it's default value, when `manager api` start, it will generate a random string to replace it.
expire_time: 3600 # jwt token expire time, in second
users: # yamllint enable rule:comments-indentation
- username: admin # username and password for login `manager api`
password: admin
- username: user
password: user
+oidcApp:
Review Comment:
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
starsz commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r953407191
##########
api/conf/conf.yaml:
##########
@@ -51,14 +51,14 @@ conf:
level: warn # supports levels, lower to higher: debug, info, warn, error, panic, fatal
file_path:
logs/error.log # supports relative path, absolute path, standard output
- # such as: logs/error.log, /tmp/logs/error.log, /dev/stdout, /dev/stderr
- # such as absolute path on Windows: winfile:///C:\error.log
+ # such as: logs/error.log, /tmp/logs/error.log, /dev/stdout, /dev/stderr
+ # such as absolute path on Windows: winfile:///C:\error.log
access_log:
file_path:
logs/access.log # supports relative path, absolute path, standard output
- # such as: logs/access.log, /tmp/logs/access.log, /dev/stdout, /dev/stderr
- # such as absolute path on Windows: winfile:///C:\access.log
- # log example: 2020-12-09T16:38:09.039+0800 INFO filter/logging.go:46 /apisix/admin/routes/r1 {"status": 401, "host": "127.0.0.1:9000", "query": "asdfsafd=adf&a=a", "requestId": "3d50ecb8-758c-46d1-af5b-cd9d1c820156", "latency": 0, "remoteIP": "127.0.0.1", "method": "PUT", "errs": []}
+ # such as: logs/access.log, /tmp/logs/access.log, /dev/stdout, /dev/stderr
+ # such as absolute path on Windows: winfile:///C:\access.log
+ # log example: 2020-12-09T16:38:09.039+0800 INFO filter/logging.go:46 /apisix/admin/routes/r1 {"status": 401, "host": "127.0.0.1:9000", "query": "asdfsafd=adf&a=a", "requestId": "3d50ecb8-758c-46d1-af5b-cd9d1c820156", "latency": 0, "remoteIP": "127.0.0.1", "method": "PUT", "errs": []}
Review Comment:
Better not modify this.
##########
api/conf/conf.yaml:
##########
@@ -71,15 +71,27 @@ conf:
authentication:
secret:
secret # secret for jwt token generation.
- # NOTE: Highly recommended to modify this value to protect `manager api`.
- # if it's default value, when `manager api` start, it will generate a random string to replace it.
+ # NOTE: Highly recommended to modify this value to protect `manager api`.
+ # if it's default value, when `manager api` start, it will generate a random string to replace it.
expire_time: 3600 # jwt token expire time, in second
users: # yamllint enable rule:comments-indentation
- username: admin # username and password for login `manager api`
password: admin
- username: user
password: user
+oidc:
+ secret:
+ secret
+ expire_time: 3600
+ apps:
+ - app_name: authing
+ client_id:
+ client_secret:
+ scope: oidc
+ state: 123456
Review Comment:
What's the state field?
##########
api/conf/conf.yaml:
##########
@@ -71,15 +71,27 @@ conf:
authentication:
secret:
secret # secret for jwt token generation.
- # NOTE: Highly recommended to modify this value to protect `manager api`.
- # if it's default value, when `manager api` start, it will generate a random string to replace it.
+ # NOTE: Highly recommended to modify this value to protect `manager api`.
+ # if it's default value, when `manager api` start, it will generate a random string to replace it.
Review Comment:
Better not modify this.
##########
api/internal/conf/conf.go:
##########
@@ -126,10 +128,26 @@ type Authentication struct {
Users []User
}
+type App struct {
+ AppName string `mapstructure:"app_name"`
+ ClientId string `mapstructure:"client_id"`
+ ClientSecret string `mapstructure:"client_secret"`
+ Scope string
Review Comment:
Do we need to add `mapstructure` of this field?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
nic-chen commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r955541803
##########
api/internal/conf/conf.go:
##########
@@ -283,6 +298,14 @@ func initAuthentication(conf Authentication) {
}
}
+func initOidc(conf Oidc) {
+ OidcConf = conf
+
+ if OidcConf.Secret == "secret" {
+ OidcConf.Secret = utils.GetFlakeUidStr()
Review Comment:
I think we should not set a random string to Secret. we could add a warning for user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a diff in pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
starsz commented on code in PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#discussion_r950858563
##########
api/conf/conf.yaml:
##########
@@ -19,26 +19,26 @@
conf:
listen:
# host: 127.0.0.1 # the address on which the `Manager API` should listen.
- # The default value is 0.0.0.0, if want to specify, please enable it.
- # This value accepts IPv4, IPv6, and hostname.
+ # The default value is 0.0.0.0, if want to specify, please enable it.
+ # This value accepts IPv4, IPv6, and hostname.
port: 9000 # The port on which the `Manager API` should listen.
- # ssl:
- # host: 127.0.0.1 # the address on which the `Manager API` should listen for HTTPS.
- # The default value is 0.0.0.0, if want to specify, please enable it.
+ # ssl:
+ # host: 127.0.0.1 # the address on which the `Manager API` should listen for HTTPS.
Review Comment:
Why do you change this?
##########
api/internal/conf/conf.go:
##########
@@ -126,10 +128,26 @@ type Authentication struct {
Users []User
}
+type App struct {
+ AppName string
+ ClientId string
+ ClientSecret string
+ Scope string
+ State string
+ RedirectUri string
Review Comment:
Should add `yaml` flag for each field.
##########
api/conf/conf.yaml:
##########
@@ -71,15 +71,27 @@ conf:
authentication:
secret:
secret # secret for jwt token generation.
- # NOTE: Highly recommended to modify this value to protect `manager api`.
- # if it's default value, when `manager api` start, it will generate a random string to replace it.
+ # NOTE: Highly recommended to modify this value to protect `manager api`.
+ # if it's default value, when `manager api` start, it will generate a random string to replace it.
expire_time: 3600 # jwt token expire time, in second
users: # yamllint enable rule:comments-indentation
- username: admin # username and password for login `manager api`
password: admin
- username: user
password: user
+oidcApp:
Review Comment:
`oidc` would be better.
##########
api/conf/conf.yaml:
##########
@@ -71,15 +71,27 @@ conf:
authentication:
secret:
secret # secret for jwt token generation.
- # NOTE: Highly recommended to modify this value to protect `manager api`.
- # if it's default value, when `manager api` start, it will generate a random string to replace it.
+ # NOTE: Highly recommended to modify this value to protect `manager api`.
+ # if it's default value, when `manager api` start, it will generate a random string to replace it.
expire_time: 3600 # jwt token expire time, in second
users: # yamllint enable rule:comments-indentation
- username: admin # username and password for login `manager api`
password: admin
- username: user
password: user
+oidcApp:
+ secret:
+ secret
+ expire_time: 3600
+ apps:
+ - appName: authing
+ clientId: 62f3bafc15fe957a20a2ab1a
+ clientSecret: 35e4d9c9a21d2176922a4b0395ec1373
Review Comment:
Better not put your config here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#issuecomment-1229102251
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2597?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2597](https://codecov.io/gh/apache/apisix-dashboard/pull/2597?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (caaf7c6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/d166405d0e40a63b219462f7f1e63e36837be33a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d166405) will **decrease** coverage by `18.16%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #2597 +/- ##
===========================================
- Coverage 68.77% 50.61% -18.17%
===========================================
Files 133 46 -87
Lines 3523 3341 -182
Branches 864 0 -864
===========================================
- Hits 2423 1691 -732
- Misses 1100 1447 +347
- Partials 0 203 +203
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-unit-test | `50.61% <100.00%> (?)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2597?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2597/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `64.58% <100.00%> (ø)` | |
| [api/internal/filter/invalid\_request.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2597/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pbnZhbGlkX3JlcXVlc3QuZ28=) | `28.57% <100.00%> (ø)` | |
| [...rnal/handler/data\_loader/loader/openapi3/import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2597/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvbG9hZGVyL29wZW5hcGkzL2ltcG9ydC5nbw==) | `79.31% <100.00%> (ø)` | |
| [web/src/libs/iconfont.js](https://codecov.io/gh/apache/apisix-dashboard/pull/2597/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9saWJzL2ljb25mb250Lmpz) | | |
| [...omponents/Upstream/components/UpstreamSelector.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2597/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvVXBzdHJlYW1TZWxlY3Rvci50c3g=) | | |
| [...c/pages/Route/components/ResultView/ResultView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2597/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1Jlc3VsdFZpZXcvUmVzdWx0Vmlldy50c3g=) | | |
| [...components/active-check/Unhealthy/HttpStatuses.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2597/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1VuaGVhbHRoeS9IdHRwU3RhdHVzZXMudHN4) | | |
| [...src/pages/SSL/components/CertificateForm/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2597/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9TU0wvY29tcG9uZW50cy9DZXJ0aWZpY2F0ZUZvcm0vaW5kZXgudHN4) | | |
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2597/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | | |
| [...mponents/Upstream/components/active-check/Type.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2597/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL2NvbXBvbmVudHMvYWN0aXZlLWNoZWNrL1R5cGUudHN4) | | |
| ... and [172 more](https://codecov.io/gh/apache/apisix-dashboard/pull/2597/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on pull request #2597: feat: Add config struct of OpenID-Connect Login
Posted by GitBox <gi...@apache.org>.
starsz commented on PR #2597:
URL: https://github.com/apache/apisix-dashboard/pull/2597#issuecomment-1229674346
> Maybe we should merge to the `next` branch now? Looks like in later versions we will use `next` branch instead of `master`? @bzp2010 @starsz
Since we will merge the `next` branch to `master`.
So both are OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org