You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by GitBox <gi...@apache.org> on 2022/09/05 13:04:14 UTC
[GitHub] [sling-org-apache-sling-distribution-journal-messages] jose-correia opened a new pull request, #13: Create MessagingProvider poller method with support for filter properties
jose-correia opened a new pull request, #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13
This PR adds a new `createPoller()` method to the `MessagingProvider` interface with support for additional filter properties.
The filter properties are created as a `Map<String, String>` and can be used to filter the data that is polled from the journal topics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] jose-correia closed pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
jose-correia closed pull request #13: Create MessagingProvider poller method with support for filter properties
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1245261695
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] joerghoh commented on a diff in pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
joerghoh commented on code in PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#discussion_r969328295
##########
src/main/java/org/apache/sling/distribution/journal/package-info.java:
##########
@@ -16,6 +16,6 @@
* specific language governing permissions and limitations
* under the License.
*/
-@org.osgi.annotation.versioning.Version("3.1.0")
+@org.osgi.annotation.versioning.Version("1.6.0")
Review Comment:
Why do you downgrade the version of this package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] cschneider commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
cschneider commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1243412941
How about making FilterProperty a simple class instead of creating it via MessagingProvider?
Also I wonder about the need for toMessagingProvider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1246671875
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1241815721
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1245269863
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1240426459
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] tmaret commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
tmaret commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1245179884
Could you document the properties semantic in the JavaDoc ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] jose-correia commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
jose-correia commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1245189329
@tmaret The API does not demand any specific semantics for these properties.
They are implemented as a very abstracted String hash table and their semantics specificities depend solely on the API client's implementation of `MessagingProvider`.
Basically the client can use any semantics (depending on his messaging provider design details), and this is completely abstract to this API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1239571966
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1239572123
Please retry analysis of this Pull-Request directly on [SonarCloud](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1237002881
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] jose-correia commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
jose-correia commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1246667523
@tmaret for example in our specific use-case we run `createPoller()` with the following `filterProperties`:
```json
{
"publishRegions": "aus"
}
```
Then our `MessagingProvider` implementation knows the exact way for filtering the topics in our specific Journal, and uses this map to create the actual filtering in the journal message:
```json
{
"properties": [
{
"name": "publishRegions",
"values": ["aus"]
}
]
}
```
Since the API is abstracted enough this way we can support other filtering implementation, its just a matter of the MessagingProvider creating the final format, since only he knows the exact semantics of the Journal integration it is supporting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1240393532
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] cschneider merged pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by "cschneider (via GitHub)" <gi...@apache.org>.
cschneider merged PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1375929097
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1239576357
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1245269379
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] cschneider commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
cschneider commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1245200805
I think what we could describe is that the poller will only listen to messages that have properties that match key and name of all the map entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] cschneider commented on a diff in pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
cschneider commented on code in PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#discussion_r970726120
##########
src/main/java/org/apache/sling/distribution/journal/MessagingProvider.java:
##########
@@ -62,11 +62,14 @@ default Closeable createPoller(
* @param topicName name of the topic
* @param reset fallback in case no assign is given or the assigned offset not valid
* @param assign opaque implementation dependent assign string (can be null)
- * @param properties list of properties to filter the topic
+ * @param filterProperties list of properties used to filter the topic messages.
Review Comment:
I would describe this only in an abstract way like:
List of properties used to filter the topic messages. Only messages that match all filterProperties keys and values will be received.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] tmaret commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
tmaret commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1245219083
Agreed, initial version was good. IMO we just need to define the parameter better. If the semantic of the keys and values depend on the implementation, let's document that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] tmaret commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
tmaret commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1245219359
Could you also share an example of implementation semantic ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] sonarcloud[bot] commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1245265112
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-distribution-journal-messages&pullRequest=13&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] cschneider commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
cschneider commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1245201717
Actually it might also make sense to name the properties "filterProperties" to make it more obvious that they are about filtering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-distribution-journal-messages] tmaret commented on pull request #13: Create MessagingProvider poller method with support for filter properties
Posted by GitBox <gi...@apache.org>.
tmaret commented on PR #13:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/13#issuecomment-1246752730
Thank you @jose-correia for the example
> Only messages that match all filterProperties keys and values will be received.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org