Re: svn commit: rev 6120 - in trunk/subversion: bindings/swig include libsvn_delta libsvn_ra_dav libsvn_ra_svn libsvn_repos libsvn_wc mod_dav_svn

[kf...@collab.net]

ghudson@tigris.org writes:
> +/** A text-delta window handler which does nothing.
> + *
> + * Editors can return this handler from apply_textdelta if they don't
> + * care about text delta windows.
> + */
> +svn_error_t *svn_delta_null_window_handler (svn_txdelta_window_t *window,
> +                                            void *baton);

Yay -- +1 all over the change.

A minor nit about this function, though: its name makes it sounds like
a function whose job is to take the null window (a window which, as we
all know, has special significance).  Which is not at all what it's
for.  Suggest

  svn_delta_noop_window_handler
  svn_delta_default_window_handler
  svn_delta_window_nonhandler  :-)

...or something similar?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 6120 - in trunk/subversion: bindings/swig include libsvn_delta libsvn_ra_dav libsvn_ra_svn libsvn_repos libsvn_wc mod_dav_svn

[Greg Hudson <gh...@MIT.EDU>]

On Mon, 2003-06-02 at 17:14, kfogel@collab.net wrote:
> A minor nit about this function, though: its name makes it sounds like
> a function whose job is to take the null window (a window which, as we
> all know, has special significance).  Which is not at all what it's
> for.

Okay.  I like noop_window_handler and default_window_handler; I'll pick
one of those and rename it later this evening or tomorrow.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org