[jira] [Commented] (LUCENE-8932) Allow BKDReader packedIndex to be off heap

["Jack Conradson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952079#comment-16952079 ] 

Jack Conradson commented on LUCENE-8932:
----------------------------------------

[~jpountz] Apologies for the delay. I have added a second constructor that takes both the IndexInput and a boolean for on/off-heap. The first constructor will select off-heap iff the IndexInput extends ByteBufferIndexInput. I made all tests uses a random boolean to determine whether to test on-heap or off-heap. Finally, I changed setPosition to throw an IOException as it's the API that's changing directly.

> Allow BKDReader packedIndex to be off heap
> ------------------------------------------
>
>                 Key: LUCENE-8932
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8932
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Jack Conradson
>            Priority: Minor
>         Attachments: LUCENE-8932.patch, LUCENE-8932.patch
>
>
> This change modifies BKDReader to read the packedIndex bytes off heap rather than load them all on heap at a single time.
> Questions for discussion:
>  # Should BKDReader only support packedIndex off heap?
>  # If not, how should the choice be made?
> Using luceneutils IndexAndSearchOpenStreetMaps present the following test results:
> with -box -points (patch)
> READER MB: 1.1345596313476562
> BEST M hits/sec: 73.34277344984474
> BEST QPS: 74.63011169783009
> with -box -points (original)
> READER MB: 1.7249317169189453
> BEST M hits/sec: 73.77125157623486
> BEST QPS: 75.06611062353801
> with -nearest 10 -points (patch)
> READER MB: 1.1345596313476562
> BEST M hits/sec: 0.013586298373879497
> BEST QPS: 1358.6298373879497
> with -nearest 10 -points (original)
> READER MB: 1.7249317169189453
> BEST M hits/sec: 0.01445208197367343
> BEST QPS: 1445.208197367343
> with -box -geo3d (patch)
> READER MB: 1.1345596313476562
> BEST M hits/sec: 39.84968715299074
> BEST QPS: 40.54914292796736
> with -box -geo3d (original)
> READER MB: 1.7456226348876953
> BEST M hits/sec: 40.45051734329004
> BEST QPS: 41.160519101846695



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org