You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/04/11 23:01:34 UTC
Re: Review Request 46030: Used initializer_list for collections in
libprocess tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46030/
-----------------------------------------------------------
(Updated April 11, 2016, 9:01 p.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Make use of init_list for std::set.
Summary (updated)
-----------------
Used initializer_list for collections in libprocess tests.
Repository: mesos
Description (updated)
-------
Used initializer_list for collections in libprocess tests.
Diffs (updated)
-----
3rdparty/libprocess/src/tests/future_tests.cpp c2eeb0e52dab08f390ec524ed727dde1a72916b3
3rdparty/libprocess/src/tests/process_tests.cpp e8ee8ee01ee9524b308452c403326e10f75b3ce5
Diff: https://reviews.apache.org/r/46030/diff/
Testing (updated)
-------
make check
Thanks,
Neil Conway
Re: Review Request 46030: Used initializer_list for collections in
libprocess tests.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46030/#review128255
-----------------------------------------------------------
Fix it, then Ship it!
Hm.. ideally there should not have been a TODO in the firewall tests, since it tends to just serve as a distraction.
3rdparty/libprocess/src/tests/future_tests.cpp (lines 469 - 474)
<https://reviews.apache.org/r/46030/#comment191671>
I tend to find an added `=` a little more clear, since it then reads as assignment to an initializer list.
- Ben Mahler
On April 11, 2016, 9:01 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46030/
> -----------------------------------------------------------
>
> (Updated April 11, 2016, 9:01 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used initializer_list for collections in libprocess tests.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/tests/future_tests.cpp c2eeb0e52dab08f390ec524ed727dde1a72916b3
> 3rdparty/libprocess/src/tests/process_tests.cpp e8ee8ee01ee9524b308452c403326e10f75b3ce5
>
> Diff: https://reviews.apache.org/r/46030/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>