You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/09/13 02:07:22 UTC

[GitHub] [activemq] chris-joys opened a new pull request #710: Update JaasAuthenticationBroker.java

chris-joys opened a new pull request #710:
URL: https://github.com/apache/activemq/pull/710


   Allow user use encrypt password to check entry detail info via web console


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] mattrpav commented on a change in pull request #710: Update JaasAuthenticationBroker.java

Posted by GitBox <gi...@apache.org>.
mattrpav commented on a change in pull request #710:
URL: https://github.com/apache/activemq/pull/710#discussion_r713220559



##########
File path: activemq-broker/src/main/java/org/apache/activemq/security/JaasAuthenticationBroker.java
##########
@@ -86,6 +88,10 @@ public void addConnection(ConnectionContext context, ConnectionInfo info) throws
     @Override
     public SecurityContext authenticate(String username, String password, X509Certificate[] certificates) throws SecurityException {
         SecurityContext result = null;
+        Properties prop = new Properties();
+    	prop.put(username, password);

Review comment:
       Please fix inconsistent spacing




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq] mattrpav commented on pull request #710: Update JaasAuthenticationBroker.java

Posted by GitBox <gi...@apache.org>.
mattrpav commented on pull request #710:
URL: https://github.com/apache/activemq/pull/710#issuecomment-924154355


   @chris-joys is there a JIRA for this change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org