You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/25 08:22:03 UTC
[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #44: feat: release 0.1.0
tzssangglass opened a new pull request #44:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #44: feat: release 0.1.0
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #44:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/44#discussion_r659117793
##########
File path: Makefile
##########
@@ -17,18 +17,18 @@
SHELL := /bin/bash -o pipefail
-VERSION ?= 0.1.0-SNAPSHOT
-RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+VERSION ?= 0.1.0
+RELEASE_SRC = apisix-java-plugin-runner-${VERSION}
Review comment:
update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #44: feat: release 0.1.0
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #44:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/44#discussion_r659117289
##########
File path: Makefile
##########
@@ -17,18 +17,18 @@
SHELL := /bin/bash -o pipefail
-VERSION ?= 0.1.0-SNAPSHOT
-RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+VERSION ?= 0.1.0
+RELEASE_SRC = apisix-java-plugin-runner-${VERSION}
Review comment:
got
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] nic-chen commented on a change in pull request #44: feat: release 0.1.0
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #44:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/44#discussion_r659062039
##########
File path: Makefile
##########
@@ -17,18 +17,18 @@
SHELL := /bin/bash -o pipefail
-VERSION ?= 0.1.0-SNAPSHOT
-RELEASE_SRC = apache-apisix-java-plugin-runner-${VERSION}-src
+VERSION ?= 0.1.0
+RELEASE_SRC = apisix-java-plugin-runner-${VERSION}
Review comment:
why remove `-src`? other projects have it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #44: feat: release 0.1.0
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #44:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/44#discussion_r658601873
##########
File path: runner-dist/apisix-runner-src-dist/pom.xml
##########
@@ -63,8 +63,8 @@
</goals>
<configuration>
<target>
- <copy file="${project.build.directory}/apisix-runner-src.tgz"
- tofile="${project.basedir}/../../dist/apache-apisix-java-plugin-runner-${project.version}-src.tgz"
+ <copy file="${project.build.directory}/apisix-java-plugin-runner.tgz"
+ tofile="${project.basedir}/../../apisix-java-plugin-runner-0.1.0.tgz"
Review comment:
got
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] nic-chen merged pull request #44: feat: release 0.1.0
Posted by GitBox <gi...@apache.org>.
nic-chen merged pull request #44:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] dmsolr commented on a change in pull request #44: feat: release 0.1.0
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #44:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/44#discussion_r658581960
##########
File path: runner-dist/apisix-runner-src-dist/pom.xml
##########
@@ -63,8 +63,8 @@
</goals>
<configuration>
<target>
- <copy file="${project.build.directory}/apisix-runner-src.tgz"
- tofile="${project.basedir}/../../dist/apache-apisix-java-plugin-runner-${project.version}-src.tgz"
+ <copy file="${project.build.directory}/apisix-java-plugin-runner.tgz"
+ tofile="${project.basedir}/../../apisix-java-plugin-runner-0.1.0.tgz"
Review comment:
I recommend replacing the version number with `${project.version}`.
And the version could exclude suffix `-RELEASE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on a change in pull request #44: feat: release 0.1.0
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on a change in pull request #44:
URL: https://github.com/apache/apisix-java-plugin-runner/pull/44#discussion_r658632700
##########
File path: runner-dist/apisix-runner-src-dist/pom.xml
##########
@@ -63,8 +63,8 @@
</goals>
<configuration>
<target>
- <copy file="${project.build.directory}/apisix-runner-src.tgz"
- tofile="${project.basedir}/../../dist/apache-apisix-java-plugin-runner-${project.version}-src.tgz"
+ <copy file="${project.build.directory}/apisix-java-plugin-runner.tgz"
+ tofile="${project.basedir}/../../apisix-java-plugin-runner-0.1.0.tgz"
Review comment:
update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org