[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24233: [SPARK-26356][SQL] remove SaveMode from data source v2

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24233: [SPARK-26356][SQL] remove SaveMode from data source v2
URL: https://github.com/apache/spark/pull/24233#discussion_r287203658
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala
 ##########
 @@ -268,9 +269,26 @@ final class DataFrameWriter[T] private[sql](ds: Dataset[T]) {
 
       import org.apache.spark.sql.execution.datasources.v2.DataSourceV2Implicits._
       provider.getTable(dsOptions) match {
+        // TODO: for backward compatibility reasons, the builtin file source needs to support all
 
 Review comment:
   Can we have an IDed TODO? `TODO:` -> `TODO(SPARK-XXX):`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org