[jira] [Commented] (PHOENIX-2183) Fix debug log line when doing secondary index WAL replay

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113970#comment-15113970 ] 

Hadoop QA commented on PHOENIX-2183:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12750941/PHOENIX-2183-v2.patch
  against master branch at commit 551cc7db93a8a2c3cc9ff15e7cf9425e311ab125.
  ATTACHMENT ID: 12750941

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 33 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/234//testReport/
Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/234//artifact/patchprocess/patchJavadocWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/234//console

This message is automatically generated.

> Fix debug log line when doing secondary index WAL replay
> --------------------------------------------------------
>
>                 Key: PHOENIX-2183
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2183
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Yuhao Bi
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2183-v2.patch, PHOENIX-2183.patch
>
>
> In Indexer#postOpen(...) we write the log in any condition.
> {code}
>     LOG.info("Found some outstanding index updates that didn't succeed during"
>         + " WAL replay - attempting to replay now.");
>     //if we have no pending edits to complete, then we are done
>     if (updates == null || updates.size() == 0) {
>       return;
>     }
> {code}
> We should only write the log when we actually doing a replay.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)