[GitHub] [pulsar] nodece commented on a diff in pull request #18336: [feat][authentication] Add JWKS support for AuthenticationProviderToken

[GitBox <gi...@apache.org>]

nodece commented on code in PR #18336:
URL: https://github.com/apache/pulsar/pull/18336#discussion_r1042378070


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderToken.java:
##########
@@ -266,7 +301,7 @@ private Key getValidationKey(ServiceConfiguration conf) throws IOException {
             final byte[] validationKey = AuthTokenUtils.readKeyFromUrl(tokenPublicKey);
             return AuthTokenUtils.decodePublicKey(validationKey, publicKeyAlg);
         } else {
-            throw new IOException("No secret key was provided for token authentication");
+            return null;

Review Comment:
   See lines 158-162.
   
   This method just gets the public or secret key. When returns null, we read the JWKS data.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org