You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Mariia Mykhailova (JIRA)" <ji...@apache.org> on 2015/09/15 23:35:46 UTC
[jira] [Comment Edited] (REEF-724) Move
ClrBridgeRuntimeConfiguration from Constants.cs to REFFFileNames.cs
[ https://issues.apache.org/jira/browse/REEF-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14745938#comment-14745938 ]
Mariia Mykhailova edited comment on REEF-724 at 9/15/15 9:35 PM:
-----------------------------------------------------------------
Looking closer at these constants, they are used in 3 places:
{{Org.Apache.REEF.Client/Common/DriverFolderPreparationHelper.cs}} which should be removed after REEF-217
{{lang/cs/Org.Apache.REEF.Driver/Bridge/ClrClientHelper.cs}} which was obsoleted in 0.13 (REEF-735) and will be removed in 0.14 (filed JIRA REEF-752 for this)
{{lang/cs/Org.Apache.REEF.Evaluator/Evaluator.cs}} which is the only use supposed to stay
It would be a lot easier to return to this move after two first occurrences are deleted from code (compared to updating code which will be deleted soon). I suggest we mark this as blocked on REEF-217 and REEF-752 and wait. What do you think?
was (Author: mariiamykhailova):
Looking closer at these constants, they are used in 3 places:
{{Org.Apache.REEF.Client/Common/DriverFolderPreparationHelper.cs}} which should be removed after REEF-217
{{lang/cs/Org.Apache.REEF.Driver/Bridge/ClrClientHelper.cs}} which was obsoleted in 0.13 (REEF-735) and will be removed in 0.14 (need to file a JIRA for this)
{{lang/cs/Org.Apache.REEF.Evaluator/Evaluator.cs}} which is the only use supposed to stay
It would be a lot easier to return to this move after two first occurrences are deleted from code (compared to updating code which will be deleted soon). I suggest we mark this as blocked on REEF-217 and REEF-735 and wait. What do you think?
> Move ClrBridgeRuntimeConfiguration from Constants.cs to REFFFileNames.cs
> ------------------------------------------------------------------------
>
> Key: REEF-724
> URL: https://issues.apache.org/jira/browse/REEF-724
> Project: REEF
> Issue Type: Task
> Components: REEF.NET
> Reporter: Mariia Mykhailova
> Assignee: Mariia Mykhailova
> Priority: Minor
>
> {noformat}
> lang/cs/Org.Apache.REEF.Common/Constants.cs:26: [Obsolete(message:"Use REEFFileNames instead.")]
> lang/cs/Org.Apache.REEF.Common/Constants.cs-27- public const string ClrBridgeRuntimeConfiguration = "clrBridge.config";
> --
> --
> lang/cs/Org.Apache.REEF.Driver/Constants.cs:137: [Obsolete(message:"Use REEFFileNames instead.")]
> lang/cs/Org.Apache.REEF.Driver/Constants.cs-138- public const string DriverBridgeConfiguration = Common.Constants.ClrBridgeRuntimeConfiguration;
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)