You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/28 01:31:40 UTC

[GitHub] [apisix] juzhiyuan opened a new issue #2882: request help: 

juzhiyuan opened a new issue #2882:
URL: https://github.com/apache/apisix/issues/2882


   ### Issue description
   
   Should we update plugins' docs to use the `disable` property instead of omitting the plugin's data to disable that plugin?
   
   e.g https://github.com/apache/apisix/blob/master/doc/plugins/api-breaker.md#disable-plugin
   
   ### Environment
   
   * apisix version (cmd: `apisix version`): No
   * OS: No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #2882: request help: use the disable property to disable plugin

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735027031


   Better not mention this experimental feature in the doc.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #2882: request help: use the disable property to disable plugin

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735027604


   OK, I was misled right now. It is **disable a plugin for a route/service**, not **disable a plugin**. We should clarify it in the doc. The current doc mess `enable / disable a plugin for a route/service` with `enable / disable a plugin`, and many people are mislead.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed issue #2882: request help: use the disable property to disable plugin

Posted by GitBox <gi...@apache.org>.
spacewander closed issue #2882:
URL: https://github.com/apache/apisix/issues/2882


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #2882: request help: use the disable property to disable plugin

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735026954


   Isn't this behavior broken now? Add a disable field doesn't trigger the `destory` method of the plugin. And re-enable a plugin doesn't the `init` method.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #2882: request help: use the disable property to disable plugin

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-760142714


   Done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on issue #2882: request help: use the disable property to disable plugin

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735033723


   
   
   This PR[1] would depend on this feature, related issue [2]
   
   [1] https://github.com/apache/apisix-dashboard/pull/898
   [2] https://github.com/apache/apisix-dashboard/issues/495


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on issue #2882: request help: use the disable property to disable plugin

Posted by GitBox <gi...@apache.org>.
membphis commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735024950


   We can add a new section about this way, add a reference to the doc of `plugin`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #2882: request help: use the disable property to disable plugin

Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735028068


   I think the plugins' doc need to be rewritten to show the difference. There is no need to show the `disable a plugin for a route/service` in every doc since they are similar.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan edited a comment on issue #2882: request help: use the disable property to disable plugin

Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #2882:
URL: https://github.com/apache/apisix/issues/2882#issuecomment-735033723


   https://github.com/apache/apisix-dashboard/pull/898/files#diff-0dc947a149da358540c612806141422ec2dab3029fcc1b255953be994655ec74R151-R160
   
   This PR[1] would depend on this feature, related issue [2]
   
   [1] https://github.com/apache/apisix-dashboard/pull/898
   [2] https://github.com/apache/apisix-dashboard/issues/495


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org